ext/session: Remove redundant parentheses in session tests - #23609
kamil-tekiela merged 1 commit into
Conversation
8828c63 to
e7b867b
Compare
|
Dropped session_id_error3.phpt from the PR because my editor kept changing the invisible characters and I can't be bothered fighting it. |
|
I am not sure I understand the purpose. What does it improve? |
Users tend to get confused when faced with unnecessary parentheses, e.g. when concatenation is involved. Since these lines are not part of the tests but of the SKIPIF, we don't need to be concerned about this breaking the tests. It's just a stylistic change to make it easier for users to visually parse the code. |
|
It doesn't make sense to me changing such code if there are no style guidelines specifying the standard in the project. |
That is true, but a precedent exists. In the past, we have fixed it in other extensions. If we can prevent future confusion, I think we should. It's a minor nit that isn't going to break anything and touches lines that are of little importance to git blame. |
jorgsowa
left a comment
There was a problem hiding this comment.
I don't want to make any blocker, but we should really have styleguide for code format.
* upstream/master: (99 commits) NEWS Fix property hook escape analysis causing misoptimization Fix __isset escape analysis causing misoptimization Fix memory leak when closing a statement on a killed connection Reset field_count for OK packet (php#23890) Fix phpGH-23986: Clear the realpath cache in the child after pcntl_fork() (php#23987) ext/standard: Remove redundant if-branch in rot13 (php#23795) ext/pdo: Throw a ValueError from bindColumn() for an unknown column (php#23835) Zend: rename zend_object* parameter to "this_ptr" for zend_call_* functions (php#23989) ext/pdo: Release driver options after bindParam and bindColumn tests: Raise test stack for stream error depth limit under MSan (php#23985) Zend: Remove zend_atomic.[ch] abstraction (php#23927) fibers: fix phpGH-23921 (Fibers start with error_reporting = 0 when the error_reporting INI directive is not set) ext/pdo: Keep statement class when ATTR_STATEMENT_CLASS is rejected Verify bundled sources using CI - Opcache JIT IR (php#20179) zend_portability: Simplify definition of `ZEND_NORETURN` (php#23908) Fix phpGH-23758: PDO_Firebird returns null for empty BLOBs (php#23763) Remove redundant parentheses in session tests (php#23609) Update IR (php#23861) Fix OSS-Fuzz #552682112: assertion failure wrt zp_arg_must_be_sent_by_ref() (php#23760) ... # Conflicts: # ext/openssl/xp_ssl.c
No description provided.