Conversation
…he error_reporting INI directive is not set) The way zend_fiber_execute() was querying the error reporting was rather strange, as it didn't rely on the value of EG(error_reporting). This was done as the @ silence operator could leak inside the body of fibers, however this situation can be detected more simply if the value of EG(error_reporting) and the value of the INI setting differ.
arnaud-lb
reviewed
Sep 28, 2026
| zend_long error_reporting = EG(error_reporting); | ||
| /* A silence operator @ may modify the error_reporting value without changing the underlying INI value */ | ||
| if (error_reporting != zend_ini_long_literal("error_reporting")) { | ||
| error_reporting = E_ALL; |
Member
There was a problem hiding this comment.
This is pre-existing, but E_ALL looks wrong here as it may widen the original error reporting:
error_reporting(E_WARNING);
@(new Fiber(function () {
var_dump(error_reporting()); // expected: E_WARNING, actual: E_ALL
}))->start();
Member
Author
There was a problem hiding this comment.
Added a new test, as indeed this was being messed with.
Turns out we can just use zend_ini_long_literal() (at least on 8.6+)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way zend_fiber_execute() was querying the error reporting was rather strange, as it didn't rely on the value of EG(error_reporting). This was done as the @ silence operator could leak inside the body of fibers, however this situation can be detected more simply if the value of EG(error_reporting) and the value of the INI setting differ.
I'm not fully confident this is the correct fix but the only test that fails if we don't query the INI setting is
Zend/tests/fibers/silence-operator-outside-fiber.phpt.Note: the new test always succeeded as the test runner (I think) has a default INI setting.