Skip to content

Fix GH-24006: Skip gh18431.phpt when libzip lacks progress callbacks - #24009

Closed
lazerg wants to merge 1 commit into
php:PHP-8.4from
lazerg:fix/gh-24006-zip-progress-skip
Closed

lazerg wants to merge 1 commit into
php:PHP-8.4from
lazerg:fix/gh-24006-zip-progress-skip

Conversation

@lazerg

@lazerg lazerg commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

ZipArchive::registerProgressCallback() only exists when PHP is built against libzip 1.3.0 or newer, so gh18431.phpt dies with "Call to undefined method" on older libzip. The other progress callback tests (oo_progress.phpt, gh23276_progress_callback.phpt, gh23747.phpt) already skip in that case, this one was missing the check.

Fixes GH-24006

@devnexen devnexen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct

@LamentXU123 LamentXU123 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

LamentXU123 added a commit that referenced this pull request Sep 30, 2026
* PHP-8.6:
  Fix GH-24006: Skip gh18431.phpt when libzip lacks progress callbacks (#24009)
pull Bot pushed a commit to wudi/php-src that referenced this pull request Sep 30, 2026
* PHP-8.4:
  Fix phpGH-24006: Skip gh18431.phpt when libzip lacks progress callbacks (php#24009)
pull Bot pushed a commit to wudi/php-src that referenced this pull request Sep 30, 2026
* PHP-8.5:
  Fix phpGH-24006: Skip gh18431.phpt when libzip lacks progress callbacks (php#24009)
arnaud-lb added a commit to arnaud-lb/php-src that referenced this pull request Sep 30, 2026
* PHP-8.6: (61 commits)
  zend_hrtime: use CLOCK_MONOTONIC instead of CLOCK_MONOTONIC_RAW (php#23790)
  sapi/cli: Fix built-in server truncating responses after a partial write
  Fix phpGH-24006: Skip gh18431.phpt when libzip lacks progress callbacks (php#24009)
  Updated to version 2026.5 (2026e)
  Fix phpGH-23896: Assertion failure in zend_call_function() after a throwing deprecation
  NEWS
  ext/gd: fix undefined behavior with GIFs with problematic LZW compression data
  Document missing deprecation entries for PHP 8.6 (php#23972)
  ext/tidy: Reject tidyNode use after the document is reparsed
  ext/bcmath: Clear the sign of BcMath\Number results that truncate to zero
  Fix phpGH-23980: ZEND_ASSERT violation @ ZEND_INCLUDE_OR_EVAL (include/eval run with a pending exception)
  Fix phpGH-23842: skipLazyInitialization() copies unresolved constant defaults
  Fall back to epoll_wait when epoll_pwait2 is unavailable at runtime (php#23825)
  openssl: Fix memory leak by doing early salt validation
  ext/libxml: Keep SimpleXML children alive across reconstruction
  Fix phpGH-23741: pdo_dblib use-after-free of statement error state
  NEWS
  Fix property hook escape analysis causing misoptimization
  Fix __isset escape analysis causing misoptimization
  Fix memory leak when closing a statement on a killed connection
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants