Repository navigation
Conversation
jrfnl
marked this pull request as draft
August 6, 2021 10:58
Contributor
Author
|
Changed to draft PR to wait for PR #45 to be merged first. I will rebase after. |
While PHP 8.1 has not been released yet, it is common to allow such a build to fail. However, as the tests currently pass, I see no reason to do so. If they pass now, let's make sure it stays that way.
jrfnl
force-pushed
the
feature/ghactions-start-testing-against-php-8.1
branch
from
August 6, 2021 11:40
8ada2d1 to
b72847c
Compare
Contributor
Author
|
Rebased after the merge of #45 |
jrfnl
marked this pull request as ready for review
August 6, 2021 11:41
Member
|
Thanks, this is the first one that's fully running on php 8.1 now 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While PHP 8.1 has not been released yet, it is common to allow such a build to fail.
However, as the tests currently pass (after all the other PRs have now been merged), I see no reason to do so. If they pass now, let's make sure it stays that way.
Fixes #37 (in combination with the previous PRs)