Repository navigation
Conversation
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR introduces a substantial secret-backed Pen CLI integration and a new default-enabled CI artifact workflow, alongside a large checked-in design asset. It also adds explicit static-analysis diagnostic suppressions, so the changes warrant human review. You can add or adjust custom eligibility rules. Learn more. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (16)
📒 Files selected for processing (5)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe PR adds an exporter for Pen marketing layouts that uses iOS screenshots, validates the generated images, and uploads them through the mobile screenshot workflow. It also adds export documentation and tests for input preparation. ChangesPen asset export
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant Workflow as pen-assets job
participant Screenshots as iOS screenshot artifact
participant Exporter as mobile-showcase-assets.ts
participant PenCLI as Pen CLI
participant Layouts as Pen layout artifact
Workflow->>Screenshots: Download iOS screenshots
Workflow->>Exporter: Run export with appearance and theme
Exporter->>PenCLI: Export Pen layouts
PenCLI-->>Exporter: Return layout images
Exporter->>Exporter: Normalize and validate seven images
Exporter-->>Workflow: Write validated layouts
Workflow->>Layouts: Upload layouts
Suggested reviewers: Merge Risk: ⚪ Minimal · up to No concrete issue requiring a change before merge was established. The template image references could not be fully checked. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The new export is limited to a manually started screenshot workflow and validates images before upload. It also introduces a credential-bearing third-party renderer. No specific security failure was established, but the template and exact renderer behavior were not fully verified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Reviewed the final feedback against 54a880e. All 16 linked template images were checked, and the independent Linux cloud run exported all 14 finished layouts and 14 reference renders. Every cloud image was pixel-identical to its corresponding verified local render; the PR body links the downloadable evidence. The docstring-coverage warning is intentionally left unchanged: this contribution was explicitly scoped to avoid adding code comments or docstrings. Usage, setup, and limits are covered in the operations guide, and the focused tests cover screenshot replacement and input validation. There are no actionable inline findings or unresolved review threads. Macroscope correctness passed, but its eligibility policy requires human review for this integration. A maintainer must also configure the upstream PEN_CLI_KEY secret before using the default-enabled export. |
|
Note Written by Thanks for this. I'm closing it as part of PR triage. Right now we're only taking focused bug fixes from outside contributors (see Read this first), and this PR is not one. From the review: Adds pen cli exports, a required secret, and marketing templates to the working screenshot workflow; outside feature and ci tooling without a defect. It has also had no activity for 16 days. If this is still important to you, message me on Twitter at @maria_rcks and I'll take another look. |
What changed and why
After iOS capture validation, the workflow exports G dark and H light Pen designs as seven 1290×2796 RGB PNGs per appearance/palette in
app-store-pen-layouts. This generates fresh App Store artwork entirely on cloud runners, with no open Pen app, AI agent, or running laptop.Only G/H, their shared components, and linked images are checked in. Pinned Pen CLI 0.3.9 exports at scale 1 from a temporary copy, replacing six phone screenshots while preserving text, phone frames, crop modes, callout artwork, and testimonials. Missing captures, export errors, or wrong dimensions fail the job. Existing raw iOS, iPad, and Google Play artifacts remain unchanged.
Verification and images
reference/, 14 finished images inapp-store/pen/, and source captures. Inline attachments need upstream write access, which this account lacks.Setup and limits
A maintainer must add the upstream Actions secret
PEN_CLI_KEY; the supplied key exists only as a test-fork Actions secret, never in this PR. Export defaults on; disablepen_assetsfor raw captures only. These are iPhone layouts, not stretched iPad/Android designs. Callouts and testimonials stay fixed. Nothing uploads to either store. The operations guide covers setup, options, usage, and troubleshooting.Model: GPT-6 Astra, high reasoning. Harness: Codex in T3 Code.
Summary by CodeRabbit