Skip to content

[codex] migrate Effect.fn in apps/server/src/persistence/Layers/Sqlite.ts - #1631

Merged
juliusmarminge merged 3 commits into
mainfrom
codex/effect-fn-apps-server-src-persistence-layers-sqlite
Apr 1, 2026
Merged

juliusmarminge merged 3 commits into
mainfrom
codex/effect-fn-apps-server-src-persistence-layers-sqlite

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Apr 1, 2026 •

Copy link
Copy Markdown
Member

Summary

  • migrate the remaining () => Effect.gen(...) wrapper in apps/server/src/persistence/Layers/Sqlite.ts to Effect.fn
  • keep this PR scoped to a single file as part of the checklist split

Why

  • finish the remaining checklist migrations without batching multiple files into one review
  • keep exact-empty-arg Effect.gen wrappers out of the codebase

Validation

  • bun fmt
  • bun lint
  • packages/shared: bun run test src/DrainableWorker.test.ts
  • apps/server: bun run test src/provider/Layers/EventNdjsonLogger.test.ts src/provider/Layers/ProviderRegistry.test.ts src/provider/Layers/ProviderService.test.ts src/provider/Layers/ProviderAdapterRegistry.test.ts src/keybindings.test.ts src/open.test.ts
  • apps/server: bun run test src/orchestration/projector.test.ts
  • apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "returns deterministic read models for repeated reads"
  • apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "archives and unarchives threads through orchestration commands"
  • apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "streams persisted domain events in order"

Notes

  • validation was run from the completed checklist scratch branch before splitting these per-file PRs
  • bun run test and bun typecheck at the repo root currently fail in apps/web because @effect/atom-react cannot be resolved
  • apps/server still has unrelated pre-existing typecheck failures outside this file

Note

Migrate makeRuntimeSqliteLayer and makeSqlitePersistenceLive to Effect.fn in Sqlite.ts

Refactors two factory functions in Sqlite.ts to use Effect.fn with named identifiers instead of plain arrow functions wrapping Effect.gen. Internal logic and runtime behavior are unchanged.

Macroscope summarized dfca081.


Note

Low Risk
Low risk refactor limited to apps/server/src/persistence/Layers/Sqlite.ts, with no logic changes beyond how the effects are wrapped/unwrapped. Main risk is subtle type/Layer unwrapping behavior differences, but the same Layer.unwrap and effect flow are preserved.

Overview
Refactors apps/server/src/persistence/Layers/Sqlite.ts to wrap makeRuntimeSqliteLayer and makeSqlitePersistenceLive with named Effect.fn generators instead of arrow functions returning Effect.gen(...).pipe(Layer.unwrap).

Behavior should remain the same (runtime selection between bun/node loaders, setup PRAGMAs/migrations, and layer composition), but the functions now carry explicit Effect names and use the Effect.fn(..., Layer.unwrap) form.

Written by Cursor Bugbot for commit dfca081. This will update automatically on new commits. Configure here.

Co-authored-by: codex <codex@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Apr 1, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d6f8ac82-ca81-404d-a03c-b28ee26206ca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/effect-fn-apps-server-src-persistence-layers-sqlite

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Apr 1, 2026
@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Apr 1, 2026
@juliusmarminge
juliusmarminge marked this pull request as ready for review April 1, 2026 15:35
@juliusmarminge
juliusmarminge enabled auto-merge (squash) April 1, 2026 15:35
@juliusmarminge
juliusmarminge merged commit 9f6686a into main Apr 1, 2026
12 of 13 checks passed
@juliusmarminge
juliusmarminge deleted the codex/effect-fn-apps-server-src-persistence-layers-sqlite branch April 1, 2026 16:14
youpele52 referenced this pull request in youpele52/bigbud Jun 17, 2026
…e.ts (#1631)

Co-authored-by: codex <codex@users.noreply.github.com>
NeilTheFisher pushed a commit to NeilTheFisher/t3code that referenced this pull request Aug 18, 2026
…e.ts (pingdotgg#1631)

Co-authored-by: codex <codex@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant