fix(server): schedule_task no longer tells agents every run returns to their thread by tiliakoos · Pull Request #16875 · pingdotgg/t3code

tiliakoos · 2026-10-07T15:55:57Z

Problem

Since #15219, schedule_task without bindToCurrentThread posts runs into the calling thread only when the task is in that thread's own project; anywhere else each run launches a fresh thread, and an explicit true is rejected. The field's published description and the orchestration instructions still tell agents runs return to this thread by default, so an agent scheduling into another project tells the user results will arrive here, and they don't. Closes #16185.

Change

Text only, no behaviour change; in the contracts it is an annotation, and the schema type is unchanged. The field description and its JSDoc in packages/contracts/src/orchestratorMcp.ts, and the sentence in T3_CODE_ORCHESTRATION_INSTRUCTIONS, now state the default scheduleTask applies, in the terms the schedule_task tool description already uses. The instructions constant is shared by every provider's path, so one edit covers them all.

The triage also points at #15699 (docs) and #15913 (telemetry), which carry the same older assumption. They are open pull requests of their own, so they are left alone here.

Scope and approval

Triaged bug #16185, confirmed on main with these files named: #16185 (comment)

Verification

vp test run apps/server/src/mcp/toolkits/orchestrator/tools.test.ts packages/provider-core/src/server/orchestrationInstructions.test.ts: the two new tests fail on main (2 failed, 10 passed) and pass with the change (12 passed). One reads the schema through Tool.getJsonSchema(ScheduleTaskTool), which is what McpHttpServer serves as the tool's inputSchema; the other reads the instructions constant.

The text agents receive, printed from the same two sources.

Before:

bindToCurrentThread: True (default) posts each run into this thread; false creates a fresh top-level thread per run.
instructions: By default runs return to the current thread, which suits orchestrating: each trigger arrives here and you delegate or dedupe; set `bindToCurrentThread=false` only when the user wants a fresh thread for every run.

After:

bindToCurrentThread: In this thread's project, true (the default) posts each run into this thread and false creates a fresh top-level thread per run. In another project, or without a calling thread, each run launches a fresh thread and true is rejected.
instructions: In this thread's project, runs return to the current thread by default, which suits orchestrating: each trigger arrives here and you delegate or dedupe; set `bindToCurrentThread=false` only when the user wants a fresh thread for every run. A task scheduled into another project launches a fresh thread for every run.

The new text matches scheduleTask in apps/server/src/mcp/OrchestratorMcpService.ts: input.bindToCurrentThread ?? (parent !== undefined && parent.thread.projectId === projectId), with invalid_request for an explicit true without a calling thread or in another project.
vp lint and vp fmt --check on the four files, and the @t3tools/contracts and server typechecks, pass.
Not checked: an agent reading the new text in a running app. Nothing but the text changes.

Claude Opus 5.5 via T3 Code

…o their thread Since pingdotgg#15219 an omitted bindToCurrentThread binds only in the calling thread's own project; the field description and the orchestration instructions now say so.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

macroscopeapp · 2026-10-07T15:57:36Z

Approvability

Verdict: Approved at f62ac0b

Macroscope's review found this PR approvable — This is a narrowly scoped guidance and schema-description correction with tests; the scheduler’s actual default behavior and implementation are unchanged. Its only runtime effect is improving agent instructions for cross-project scheduling, with no new capability or production-side effect.

No code changes detected at ac39a6f. Prior analysis still applies.

^{You can add or adjust custom eligibility rules. Learn more.}

coderabbitai

Pre-merge checks failed. Please resolve the failing checks before merging.

coderabbitai · 2026-10-07T16:03:01Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.config.ts
Review profile: CHILL
Plan: Advanced
Run ID: 1e9a8fe1-d2a4-4cca-91a2-19a892bb72e7

📥 Commits

Reviewing files that changed from the base of the PR and between 611132c and f62ac0b.

📒 Files selected for processing (4)

apps/server/src/mcp/toolkits/orchestrator/tools.test.ts
apps/server/src/provider/T3OrchestrationInstructions.test.ts
apps/server/src/provider/T3OrchestrationInstructions.ts
packages/contracts/src/orchestratorMcp.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

The bindToCurrentThread schema description and orchestration instructions now distinguish scheduled runs in the calling thread’s project from runs in another project or without a calling thread. Tests check the updated guidance.

Changes

Scheduled task thread-default guidance

Layer / File(s)	Summary
Update thread-default guidance and tests `packages/contracts/src/orchestratorMcp.ts`, `apps/server/src/provider/T3OrchestrationInstructions.ts`, `apps/server/src/mcp/toolkits/orchestrator/tools.test.ts`, `apps/server/src/provider/T3OrchestrationInstructions.test.ts`	The schema description and orchestration instructions state that runs in the calling thread’s project use that thread by default. Runs in another project or without a calling thread launch a fresh thread per run. Tests check the updated descriptions.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other · Severity of issue fixed: Low

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to f62ac

The updated guidance matches the existing scheduling behavior, and no material merge risk remains.

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

Ignore (reviewers only)

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Approvability		The pull request changes agent instructions in `apps/server/src/provider/T3OrchestrationInstructions.ts`. The changed `T3_CODE_ORCHESTRATION_INSTRUCTIONS` text is consumed by Codex, Claude, Pi, and AC…	This pull request needs a maintainer's review. Review the revised `schedule_task` guidance in `apps/server/src/provider/T3OrchestrationInstructions.ts` before approval.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check		Issue `#16185` requires agent-facing documentation to describe the project-dependent default for `bindToCurrentThread`. The schema test checks the generated `ScheduleTaskTool` input schema. The updated …
Out of Scope Changes check		The reported changes are limited to the `bindToCurrentThread` documentation, the shared orchestration instruction text, and tests for those two outputs. Each change supports issue `#16185`. No unrelated…
Description check		The description includes complete Problem, Change, Scope and approval, and Verification sections. It explains the behavior mismatch, the text-only fix, the linked issue and approval, focused test resu…
Title check		The title clearly summarizes the main change: correcting agent-facing guidance so schedule_task no longer incorrectly says every run returns to the current thread.

Full details: Approvability

Explanation

The pull request changes agent instructions in apps/server/src/provider/T3OrchestrationInstructions.ts. The changed T3_CODE_ORCHESTRATION_INSTRUCTIONS text is consumed by Codex, Claude, Pi, and ACP provider prompts. This matches the rule that changes to agent instructions require maintainer review.

Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

…task-bind-default

maria-rcks · 2026-10-17T00:43:51Z

Note

Written by claude-opus-5-5 on behalf of Maria

Thanks for this. I'm closing it as part of PR triage. Right now we're only taking focused bug fixes from outside contributors (see Read this first), and this PR is not one.

From the review: This changes schedule_task descriptions and agent guidance for cross-project runs without changing scheduling behavior. Guidance changes require prior maintainer agreement.

If you think this was a mistake, message me on Twitter at @maria_rcks and I'll take another look.

fix(server): schedule_task no longer tells agents every run returns t…

f62ac0b

…o their thread Since pingdotgg#15219 an omitted bindToCurrentThread binds only in the calling thread's own project; the field description and the orchestration instructions now say so.

Copilot AI balanced review requested due to automatic review settings October 7, 2026 15:55

Copilot AI reviewed Oct 7, 2026

github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Oct 7, 2026

macroscopeapp Bot approved these changes Oct 7, 2026

View reviewed changes

coderabbitai Bot requested changes Oct 7, 2026

View reviewed changes

Merge remote-tracking branch 'upstream/main' into fix/16185-schedule-…

ac39a6f

…task-bind-default

juliusmarminge added the macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews label Oct 11, 2026 — with ChatGPT Codex Connector

maria-rcks closed this Oct 17, 2026

tiliakoos deleted the fix/16185-schedule-task-bind-default branch October 17, 2026 03:00

lukemaj mentioned this pull request Oct 19, 2026

Scheduled runs after the cache window start in a fresh thread by default toolboxmd/chromeria#521

Closed

5 tasks

Navigation Menu

Repository navigation

fix(server): schedule_task no longer tells agents every run returns to their thread - #16875

fix(server): schedule_task no longer tells agents every run returns to their thread#16875
tiliakoos wants to merge 2 commits into
pingdotgg:mainfrom
tiliakoos:fix/16185-schedule-task-bind-default

tiliakoos commented Oct 7, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

macroscopeapp Bot commented Oct 7, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot commented Oct 7, 2026 •

edited

Loading

Walkthrough

Changes

Pre-merge checks failed

Uh oh!

maria-rcks commented Oct 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

tiliakoos commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Change

Scope and approval

Verification

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

macroscopeapp Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Pre-merge checks failed

❌ Failed checks (1 error)

Uh oh!

maria-rcks commented Oct 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tiliakoos commented Oct 7, 2026 •

edited

Loading

macroscopeapp Bot commented Oct 7, 2026 •

edited

Loading

coderabbitai Bot commented Oct 7, 2026 •

edited

Loading