Skip to content

fix(mobile): iPad composer accepts dragged screenshots #17721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kaovilai wants to merge 5 commits into
base: main
Choose a base branch
from
+29 −6
Draft

fix(mobile): iPad composer accepts dragged screenshots #17721

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7073f47
fix(mobile): iPad composer accepts dragged screenshots
kaovilai Oct 10, 2026
024c4bd
fix(mobile): load dropped images by their registered type
kaovilai Oct 10, 2026
57f81cc
fix(mobile): iPad composer accepts image-only drops
kaovilai Oct 11, 2026
b418027
Merge remote-tracking branch 'origin/main' into takeover-17721-resume
juliusmarminge Oct 19, 2026
900f953
fix(mobile): respect composer locks during image drops
juliusmarminge Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 29 additions & 6 deletions apps/mobile/modules/t3-composer-editor/ios/T3ComposerEditorView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ private final class ComposerTextView: UITextView {
}

group.notify(queue: .main) { [weak self] in
guard let self, !self.isReadOnly else {
guard let self, self.isEditable, !self.isReadOnly else {
return
}
let urls = images.compactMap { $0 }.compactMap(Self.writeTemporaryImage)
Expand Down Expand Up @@ -437,7 +437,7 @@ private final class ComposerTextView: UITextView {
}
}

public final class T3ComposerEditorView: ExpoView, UITextViewDelegate, UITextDropDelegate, UIGestureRecognizerDelegate {
public final class T3ComposerEditorView: ExpoView, UITextViewDelegate, UITextDropDelegate, UIDropInteractionDelegate, UIGestureRecognizerDelegate {
private let textView = ComposerTextView()
private let placeholderLabel = UILabel()
private var value = ""
Expand Down Expand Up @@ -488,6 +488,7 @@ public final class T3ComposerEditorView: ExpoView, UITextViewDelegate, UITextDro
clipsToBounds = false
textView.delegate = self
textView.textDropDelegate = self
textView.addInteraction(UIDropInteraction(delegate: self))
textView.backgroundColor = .clear
textView.textContainerInset = .zero
textView.textContainer.lineFragmentPadding = 0
Expand Down Expand Up @@ -797,7 +798,7 @@ public final class T3ComposerEditorView: ExpoView, UITextViewDelegate, UITextDro
guard !isReadOnly else {
return UITextDropProposal(operation: .cancel)
}
guard droppedImageProviders(in: drop) != nil else {
guard droppedImageProviders(in: drop.dropSession) != nil else {
return drop.suggestedProposal
}

Expand All @@ -816,14 +817,36 @@ public final class T3ComposerEditorView: ExpoView, UITextViewDelegate, UITextDro
guard !isReadOnly else {
return
}
guard let imageProviders = droppedImageProviders(in: drop) else {
guard let imageProviders = droppedImageProviders(in: drop.dropSession) else {
return
}
textView.loadImages(from: imageProviders)
}

private func droppedImageProviders(in drop: UITextDropRequest) -> [NSItemProvider]? {
let providers = drop.dropSession.items.map(\.itemProvider)
// Support image drops that do not reach UITextDropDelegate.
public func dropInteraction(_ interaction: UIDropInteraction, canHandle session: UIDropSession) -> Bool {
textView.isEditable && !isReadOnly && droppedImageProviders(in: session) != nil
}

public func dropInteraction(
_ interaction: UIDropInteraction,
sessionDidUpdate session: UIDropSession
) -> UIDropProposal {
guard textView.isEditable, !isReadOnly, droppedImageProviders(in: session) != nil else {
return UIDropProposal(operation: .cancel)
}
return UIDropProposal(operation: .copy)
}

public func dropInteraction(_ interaction: UIDropInteraction, performDrop session: UIDropSession) {
guard textView.isEditable, !isReadOnly, let imageProviders = droppedImageProviders(in: session) else {
return
}
textView.loadImages(from: imageProviders)
}

private func droppedImageProviders(in session: UIDropSession) -> [NSItemProvider]? {
let providers = session.items.map(\.itemProvider)
guard !providers.isEmpty,
providers.allSatisfy({ $0.canLoadObject(ofClass: UIImage.self) }) else {
return nil
Expand Down
Loading