Skip to content

fix(devices): keep long diagnostics from hiding device controls #19973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 2 commits into from
Oct 18, 2026
+7 −2
Merged

fix(devices): keep long diagnostics from hiding device controls #19973

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0473b6f
fix(devices): keep long diagnostics from hiding device controls
Quicksaver Oct 15, 2026
a0b1013
fix(devices): bound failed-host diagnostics in the empty state
Quicksaver Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions apps/web/src/components/device/DevicePanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,9 @@ export function DevicePanel(props: {
{hostReady && !activeDevice && state.hostStatusDetail ? (
<div
role="status"
className="whitespace-pre-line border-b px-3 py-2 text-xs text-muted-foreground"
aria-label="Device host diagnostics"
tabIndex={0}
className="max-h-32 shrink-0 overflow-y-auto whitespace-pre-line break-words border-b px-3 py-2 text-xs text-muted-foreground"
Comment thread
Quicksaver marked this conversation as resolved.
>
{state.hostStatusDetail}
</div>
Expand Down Expand Up @@ -229,7 +231,10 @@ export function DevicePanel(props: {
{grouped.length === 0 ? (
<>
<Smartphone className="size-6 opacity-60" />
<p className="max-w-sm">
<p
className="max-h-32 w-full max-w-sm overflow-y-auto whitespace-pre-line break-words"
tabIndex={state.hostStatus === "failed" ? 0 : undefined}
>
{state.hostStatus === "failed"
? (state.hostStatusDetail ?? "The device hub failed to start.")
: "No simulators or emulators were found on this environment."}
Expand Down
Loading