Skip to content

fix(web): settings scope pickers stay in reach while you scroll #20003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashx-j wants to merge 5 commits into
base: main
Choose a base branch
from
+3 −3
Open

fix(web): settings scope pickers stay in reach while you scroll #20003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a12ebcf
fix(web): keep the settings scope pickers pinned while scrolling
ashx-j Oct 15, 2026
0dcb833
Merge remote-tracking branch 'origin/main' into fix/settings-sticky-s…
juliusmarminge Oct 19, 2026
367e86f
fix(web): keep settings scope pickers visible while scrolling
juliusmarminge Oct 19, 2026
68ef689
fix(web): merge main while preserving sticky settings scope
maria-rcks Oct 26, 2026
83669a3
Merge main into fix/settings-sticky-scope
ashx-j Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/web/src/components/settings/SettingsScopeSentence.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export function SettingsScopeSentence() {
onChange: scope.selectScope,
};
return (
<p className="flex min-w-0 flex-wrap items-center gap-x-1.5 gap-y-1 px-3 text-sm text-muted-foreground sm:px-4">
<p className="sticky top-0 z-10 -mt-6 -mb-3 flex min-w-0 flex-wrap items-center gap-x-1.5 gap-y-1 bg-background px-3 pt-6 pb-3 text-sm text-muted-foreground sm:px-4">
<span className="flex min-w-0 items-center gap-1.5">
<span className="shrink-0">Applying settings for</span>
<ProjectScopeMenu {...props} />
Expand Down Expand Up @@ -140,7 +140,7 @@ function ScopeMenu({
<Trigger
aria-label={`${ariaLabel}: ${label}`}
render={<Button variant="outline" size="sm" />}
className="min-w-0 max-w-72"
className="min-w-0 max-w-72 shrink"
>
{icon}
<span className="min-w-0 truncate">{label}</span>
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/components/settings/settingsLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ export function SettingsPageContainer({
onTargetHandled={clearTargetHash}
>
<div
className="topbar-scroll-fade scrollbar-gutter-both flex-1 overflow-y-auto"
className="topbar-scroll-fade scrollbar-gutter-both flex-1 scroll-pt-24 overflow-y-auto"
data-settings-page-scroll
>
<WorkspacePageContainer width={width} className={cn("gap-8", className)}>
Expand Down
Loading