Skip to content

fix(server): update Device Hub to 0.17.2 - #21861

Closed
gwdp wants to merge 1 commit into
pingdotgg:mainfrom
gwdp:gwdp/bump-expo-device-hub-0.17.2
Closed

gwdp wants to merge 1 commit into
pingdotgg:mainfrom
gwdp:gwdp/bump-expo-device-hub-0.17.2

Conversation

@gwdp

@gwdp gwdp commented Oct 19, 2026 •

Copy link
Copy Markdown

Problem

T3 pins Device Hub 0.15.3, which predates the folded Android screenshot fix and CoreDevice-owned iOS input fix.

Change

Update the managed expo-device-hub pin to 0.17.2, including its bundled ServeSim. Keep agent-device unchanged.

Scope and approval

This only advances the existing tool pin. Gabe requested the bump after release, following the request on #366.

Verification

  • Verified stable npm versions, source commits, tarball integrity and the bundled native/helper bytes against the tested artifacts.
  • EAS: four iOS 27 ownership/input cases passed; four Pixel Fold states produced valid nonblank screenshots. The Android image returned clean PNGs, so the warning-prefix fallback was not naturally exercised.
  • Local: all 11 existing device-tool installation, inventory and cleanup tests passed. The cleanup tests passed with the read-only process scan available after the sandbox blocked it initially.
  • Local integration: T3’s actual installer downloaded Hub 0.17.2 into a disposable directory; entry point, completion marker and inventory were correct, a second call reused the install without running npm, and CLI --help exited successfully. No local devices or servers were started.
  • JSON parsing, the repository formatter for the changed file and git diff --check passed. Full T3 UI integration was not run.
  • Separate QA caveat: coin-flip cold start after capture reboot remains unresolved; native UIKit input and recording recovered. This is not a full-green E2E claim.

— Codex

@gwdp

gwdp commented Oct 19, 2026

Copy link
Copy Markdown
Author

Codex changed only the managed Device Hub version pin from 0.15.3 to 0.17.2 and verified the stable npm artifacts against the EAS-tested helper bytes. Gabe directed the change; human review of the diff is pending.

— Codex

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 19, 2026
@gwdp
gwdp marked this pull request as ready for review October 19, 2026 18:34
@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 81c06d46-7653-4d74-8bfa-54e26fc8f438
📥 Commits

Reviewing files that changed from the base of the PR and between 300a356 and 722521c.

📒 Files selected for processing: 1
  • apps/server/src/device/deviceToolVersions.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The configured expo-device-hub version changes from 0.15.3 to 0.17.2.

Changes: Device tool version

Layer / File(s) Summary
Update device tool version
apps/server/src/device/deviceToolVersions.json
The configured expo-device-hub version changes from 0.15.3 to 0.17.2.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 72252

The version update matches the toolchain’s expected package entrypoint and install path. No actionable merge-blocking risk remains.

### Architecture Summary

Architecture risk: 🔵 Low · up to 72252

The change affects 1 system.

Changed systems: apps/server

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — apps/server (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in apps/server/src/device/deviceToolVersions.json: Updates the expo-device-hub version from 0.15.3 to 0.17.2.
Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the server change: updating Device Hub to version 0.17.2.
Description check Passed The description includes all required sections. It explains the problem, change, scope and approval, and detailed verification results. It also records limitations and the unresolved QA caveat.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@t3dotgg

t3dotgg commented Nov 1, 2026

Copy link
Copy Markdown
Member

Note

🤖 GPT-6.1 Terra [1m] responding on behalf of Theo

Closing because main already pins Device Hub 0.19.1, which includes both fixes. This pin-only PR would downgrade it to 0.17.2. #28346 deviceToolVersions.json

@t3dotgg t3dotgg closed this Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants