[fixfon]

Closes #22250

Problem

On macOS, the integrated terminal starts Bash as a plain interactive shell (/bin/bash with no arguments), so ~/.bash_profile is never read. Users who keep their prompt and functions there get the bare bash-3.2$ prompt. Terminal.app and VS Code start Bash as a login shell, so the same setup works there.

Change

apps/server/src/terminal/Manager.ts: shellCandidateFromCommand already passes -NoLogo to PowerShell on Windows and -o nopromptsp to zsh on non-Windows hosts, but Bash fell through with no args. It now returns args: ["-l"] when the host is darwin and the shell is bash. The /bin/bash and bash fallback candidates go through the same function, so they get -l too. Linux, Windows and other shells are unchanged.

Scope and approval

#22250 is not triaged yet. It qualifies as a very small, focused fix of an obvious bug: one platform/shell branch in shellCandidateFromCommand, next to the existing zsh and PowerShell cases, plus one test. It matches what macOS terminals already do and doesn't touch Linux or Windows.

Verification

• New test in Manager.test.ts, "starts bash as a login shell on macOS only", driven through manager.open with the host platform overridden. Cases: darwin /bin/bash and /opt/homebrew/bin/bash get ["-l"]; linux /bin/bash and win32 bash.exe get no args; zsh on darwin and linux and win32 pwsh.exe keep their current args.

  • On main without the fix: the two darwin Bash cases fail (expected undefined to deeply equal [ '-l' ]), the other five pass.
  • With the fix: Manager.test.ts and NodePtyAdapter.test.ts pass, 53/53 (rebased onto main after test: delete 11k low-signal tests so CI runs faster and flakes less #22557, test(server): ban real-clock waits in tests #22564 and test(server): prune low-value tests in apps/server (second pass) #22592, which trimmed these files).

• vp fmt --check is clean, vp lint on apps/server and the server typecheck report no errors.

• Manual check on macOS (Apple Silicon) with an isolated dev instance (server + web) and a temp HOME whose .bash_profile sets T3_LOGIN_PROFILE_LOADED=yes, opening the terminal with Cmd+J:

  	login_shell	marker	shell argv
  main	off	unset	/bin/bash
  this PR	on	yes	/bin/bash -l

• Not checked: the packaged Electron app (same server code path) and Intel Macs (same darwin check).

Claude Sonnet 5.5 (xhigh) via T3 Code.

[macroscopeapp]

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This changes the default startup behavior of every macOS Bash integrated terminal by adding the -l login-shell argument, with focused tests covering the platform and shell matrix. The implementation is small and localized, but the behavior change affects existing product sessions rather than an opt-in path.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Warning

Review limit reached

Only developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing.

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 0a3b561
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 1389e336-c51c-46a6-9958-502099dbb3ef

Commits

Reviewing files that changed from the base of the PR and between 74518c8 and 7267e6c.

Files selected for processing: 2

• apps/server/src/terminal/Manager.test.ts
• apps/server/src/terminal/Manager.ts

No actionable comments were generated in the recent review.

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: 92f658a8-38c5-4f56-9dfe-987a4bebb2b3

📥 Commits

Reviewing files that changed from the base of the PR and between 29e0d90 and 74518c8.

📒 Files selected for processing: 1

• apps/server/src/terminal/Manager.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

Walkthrough

On macOS, the terminal manager launches Bash with the -l login-shell argument. Tests cover this behavior and verify that arguments for other platforms and shells remain unchanged.

Changes: Bash terminal launch

Layer / File(s)	Summary
Select and verify shell arguments apps/server/src/terminal/Manager.ts, apps/server/src/terminal/Manager.test.ts	macOS Bash candidates now receive -l. Tests verify that Linux, Windows, zsh, and PowerShell retain their existing arguments.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · up to 74518

No actionable merge-blocking risk is established for this change.

Pre-merge checks: 4

Check name	Status	Explanation
Description check		The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains the focused exemption for the untriaged issue, lists targeted tests and results, docum…
Title check		The title clearly and concisely identifies the main change: macOS Bash terminals now start as login shells. It uses a conventional commit format and matches the implementation.
Linked Issues check		Issue #22250 requires macOS Bash terminals to start the selected Bash executable as login shells and preserve behavior for other platforms and shells. shellCandidateFromCommand now adds `args: ["-l"…
Out of Scope Changes check		The changes are limited to macOS Bash argument selection in apps/server/src/terminal/Manager.ts and focused automated coverage in Manager.test.ts. They do not change shell selection, Linux behavio…

Full details: Description check

Explanation

The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains the focused exemption for the untriaged issue, lists targeted tests and results, documents manual macOS verification, and states unverified areas.

Full details: Linked Issues check

Explanation

Issue #22250 requires macOS Bash terminals to start the selected Bash executable as login shells and preserve behavior for other platforms and shells. shellCandidateFromCommand now adds args: ["-l"] for Bash on darwin. The added Manager.test.ts coverage checks macOS Bash candidates and unchanged Linux Bash, Windows Bash, zsh, and PowerShell arguments. The server code path also covers the packaged app scenario described by the issue.

Full details: Out of Scope Changes check

Explanation

The changes are limited to macOS Bash argument selection in apps/server/src/terminal/Manager.ts and focused automated coverage in Manager.test.ts. They do not change shell selection, Linux behavior, Windows behavior, other shell arguments, or provider PATH handling.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

updated the original branch at 7267e6cd8f5aec7485988ee4013a65f95bddf43e, keeping @fixfon's commit and merging current main (0a3b561bc090). the original darwin-only -l fix and regression matrix were already minimal; i shortened the rationale comment. the diff against main is two files, 23 added lines. no focused overlapping fix was found; the related maintainer prs address environment probes instead.

verification:

• reproduced the failure using current main's Manager.ts with the existing pr regression: both macos bash cases fail because arguments are undefined.
• restored fix: Manager.test.ts and NodePtyAdapter.test.ts pass, 54 tests, through blacksmith.
• vp run check:changed passes through blacksmith: format, lint, knip, graphql, affected typechecks, and adjacent tests.
• current-head ci passes, including build/typecheck, lint, and all eight server test jobs. github reports mergeable, clean.
• two independent gpt-6.1-sol reviews of this exact head found no actionable defects. no unresolved inline findings. coderabbit's current-head check passes but its review was rate-limited; its prior review found no actionable issues.

unverified this run: real macos bash profile loading, electron, and the client terminal interaction. this vm is linux, so no macos before/after capture is claimed. the original author's macos verification remains in the description. the change applies on the server host, including remotely connected clients; linux/windows and other shell arguments are covered by the regression matrix.

ready for maria's review. the existing human-approval note remains for her decision.