Repository navigation
Conversation
…pdates fail An unrecognized Codex install path (for example a root-owned system copy under /usr/local/lib/codex) fell back to `codex update`, which exits 1 on any install it cannot identify, so the Update button could never succeed. Codex now stays manual-only unless its path is a standalone install or an installer T3 Code proves (npm, pnpm, bun, yarn, Homebrew, Vite+, ...). The new `manualWhenUnproven` definition option is opt-in, so Claude, OpenCode and Pi keep falling back to their own updaters. A failed update's message was only "Update command exited with code N.", which is all the toast shows. It now appends the last two non-empty lines of the updater's output (stderr first, then stdout), run through the same toProgressLine sanitizer that already shortens installer output for the running state, so the toast stays short and free of terminal control sequences. Fixes pingdotgg#22487
ApprovabilityVerdict: Would Approve Macroscope's review found this PR approvable — This is a bounded server-side bug fix that removes an unusable Codex update action for unrecognized installs and surfaces sanitized updater errors, with targeted regression coverage and no schema, security, or deployment impact. A capped-output edge case may make an excerpt less precise, but it does not change the limited scope of the fix. Needs human approval because:
Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly summarizes both primary changes: preventing unsupported Codex updates and showing update failure reasons. |
| Linked Issues check | |
Issue [#22487] has two coding requirements. Codex sets manualWhenUnproven: true, and the resolver returns manual-only capabilities with installPath when no installer is proven. Proven standalone a… |
| Out of Scope Changes check | |
The changes stay within issue [#22487]. The resolver option supports the Codex manual-update behavior without changing other providers. Tail capture supports the required failure excerpt and preserves… |
| Description check | |
The description covers the problem, implementation, scope, verification results, limitations, and agent details. It references issue #22487 and states that the changes were accepted in triage, but it … |
Full details: Linked Issues check
-
Explanation
Issue [
#22487] has two coding requirements. Codex setsmanualWhenUnproven: true, and the resolver returns manual-only capabilities withinstallPathwhen no installer is proven. Proven standalone and package-manager installs retain update commands. The maintenance runner adds the last two non-empty sanitized lines from stderr, or stdout when stderr is empty, to non-zero exit messages. Empty output, timeout handling, and the existingoutputfield remain unchanged. Focused tests cover the resolver, Codex paths, output selection, sanitization, bounds, and failure behavior.
Full details: Out of Scope Changes check
-
Explanation
The changes stay within issue [
#22487]. The resolver option supports the Codex manual-update behavior without changing other providers. Tail capture supports the required failure excerpt and preserves the existing output field. Tests and documentation cover the changed behavior. No unrelated production behavior is demonstrated.
Full details: Description check
-
Explanation
The description covers the problem, implementation, scope, verification results, limitations, and agent details. It references issue
#22487and states that the changes were accepted in triage, but it does not include a direct maintainer approval comment as requested by the template.
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
The output capture keeps the first 10 KB, so for an updater that wrote more than that, the failure message's last-lines excerpt came from the middle of its progress text, not its real final error. The runner now also keeps the last 4 KB of each stream while it is read and the excerpt uses that. The `output` field and its 10 KB cap are unchanged.
Closes #22487
Problem
Two parts, both accepted in triage:
/packages/standalone/. Any other path that no installer is proven for falls back tocodex update. A root-owned system install such as/usr/local/bin/codex -> /usr/local/lib/codex/releases/...therefore gets an Update button, butcodex updateexits 1 on installs it can't identify. Onmainthe resolver returns/usr/local/bin/codex updatefor that path.failureMessagereturns onlyUpdate command exited with code N.. The updater's stderr and stdout are stored inupdateState.output, but the clients renderupdateState.message, so the user never sees why the update failed.Change
packages/provider-core/src/server/maintenanceResolver.ts: a new opt-inmanualWhenUnprovendefinition option. When it is set, the final "nothing proven" return gives the manual result (withinstallPath) instead of the native-updater fallback.apps/server/src/provider/Drivers/CodexDriver.ts: Codex setsmanualWhenUnproven: true. Standalone installs and installs with a proven installer (npm, pnpm, Bun, Yarn, Homebrew, Vite+, ...) keep their update command. A Homebrew-shaped install whose brew can't be confirmed still getscodex update, as before.apps/server/src/provider/providerMaintenanceRunner.ts: a non-zero exit now readsUpdate command exited with code N: <excerpt>. The excerpt is the last two non-empty lines of stderr, or of stdout when stderr is empty, passed through the existingtoProgressLinesanitizer (strips terminal control sequences, collapses whitespace, caps a line at 200 characters). Empty output keeps the old message. Timeout and unknown-exit messages are unchanged, and so is theoutputfield.docs/internals/providers.mdanddocs/user/install.md: both said the provider's own updater runs when nothing is proven, which is no longer true for Codex.Only Codex turns the option on, so Claude, OpenCode and Pi still fall back to their own updaters. The "exits 1 on unrecognized installs" behavior is only reported for Codex, and the other updaters are documented to detect their installer themselves. Two lines instead of one because npm's last line is just a log-file pointer. If you'd rather make unproven installs manual-only for every provider, as the triage note puts it, that's a one-line change and I can switch it.
Verification
maintenanceResolver.unprovenInstall.test.ts: onmainthe unproven-install case fails (receives/usr/local/bin/codex update); the standalone and npm-global guards pass on both.CodexDriver.test.ts: a direct/usr/local/lib/codex/releases/.../bin/codexpath and a/usr/local/bin/codexsymlink both stay manual-only. They fail onmain. A linked standalone release still getscodex updatewithCODEX_HOME.providerMaintenanceFailureMessage.test.ts: stderr shown, stdout fallback, stderr preferred, ANSI stripped, 500 lines shows only the last two, a 10 KB line stays bounded, empty or whitespace-only output keeps the exit-code message. Six of these fail onmain.providerMaintenanceFailureMessage.test.tsrun a failing update: the final error of output longer than 10 KB, a cut first line of a long output, and a long line with no newline. They fail on the previous commit (809912c) and pass with 263a922.providerMaintenanceRunner.test.tsnow expectsUpdate command exited with code 1: permission denied.apps/server(CodexDriver, providerMaintenanceFailureMessage, providerMaintenanceRunner): 54/54 pass.packages/provider-coremaintenanceResolver suites: 65/65 pass. With the three production files reverted tomain, 13 of the new or updated tests fail.vp fmt --checkis clean,vp linton the touched files exits 0, and typecheck passes forpackages/provider-coreandapps/server.codex updateagainst a real system-wide install (it could modify the install), and a pass in the app UI. No client code changed; clients already rendermessage.Claude Sonnet 5.5 (xhigh) via T3 Code.