Repository navigation
fix(mobile): hide Android draft native header before first layout - #22742
Open
juliusmarminge wants to merge 1 commit into
Open
juliusmarminge wants to merge 1 commit into
juliusmarminge wants to merge 1 commit into
Conversation
juliusmarminge
marked this pull request as ready for review
October 21, 2026 08:06
Contributor
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — This one-line change alters Android's initial native-header default for the draft route, affecting first-layout product UI while leaving iOS and other routes unchanged. Because it changes a product default, human review is required. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Contributor
This was referenced Oct 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Android NewTaskDraft inherits a visible native header, then hides it after mount while drawing its own Material toolbar. Initialize the route with
headerShown: Platform.OS !== "android", following the Thread fix in #18963. This prevents the native header from participating in the draft's initial layout.Change
Fixes #22737.
Scope and approval
Fixes #22737
Triaged bug via the automated issue flow.
Reproduction scope: no Android runtime reproduction was possible on this VM (no emulator or EAS Android build). Current-main code has the same late-hide hazard as Thread. The reporter's controlled delayed-hide experiment measured a 317-physical-pixel initial header offset; it does not establish the trigger for the original persistent offset. This PR does not claim that trigger is confirmed.
At this head: eight scoped mobile suites, 74/74 tests passed; mobile typecheck passed; Stack.tsx lint passed with one existing warning outside the added line. All commands exited 0. Linux x86_64, Node 24.21.0, Vite+ 1.3.0, Vitest 5.0.5, Oxlint 1.88.0, tsc-rs 7.1.0-dev. No native app, browser, or simulator was run. All 10 matrix rows are accounted for, including all eight affected Android runtime rows explicitly unverified.
No new regression test: 0 → 0. Source-text, option-value, and wiring assertions cannot establish native layout geometry. Eight existing navigation/draft suites are retained. Native Android rows remain unverified; the issue's VM exception permits scoped tests and typecheck instead of pixel captures. iOS runtime is also unverified.
Verification
What else changes: Android's transient “Switching branch...” placeholder also starts without the native title/header; leaving that placeholder is already guarded during checkout. Both missing-project and loaded draft paths retain their existing custom toolbar. iOS retains the inherited sheet header options and initial native header visibility. Web and desktop do not use this stack; no contracts, providers, server, data, or connection-mode behavior changes.
Evidence
Head: 268b1b075c. Comparison: ea1c49419e.
Two isolated read-only reviews (Codex GPT-6.1-Sol and Claude Opus 5.5) returned
VERDICT: MERGEwithout confirmed findings at the current head. Proof-audit details are in the evidence links. Android verification is reserved for Julius; this PR is unmerged.Model and harness: GPT-6.1-Sol through Codex in T3 Code; independent review by Claude Opus 5.5 through Claude Agent.