Skip to content

fix(mobile): hide Android draft native header before first layout - #22742

Open
juliusmarminge wants to merge 1 commit into
mainfrom
fix/issue-22737
Open

juliusmarminge wants to merge 1 commit into
mainfrom
fix/issue-22737

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Problem

Android NewTaskDraft inherits a visible native header, then hides it after mount while drawing its own Material toolbar. Initialize the route with headerShown: Platform.OS !== "android", following the Thread fix in #18963. This prevents the native header from participating in the draft's initial layout.

Change

Fixes #22737.

Scope and approval

Fixes #22737

Triaged bug via the automated issue flow.

Reproduction scope: no Android runtime reproduction was possible on this VM (no emulator or EAS Android build). Current-main code has the same late-hide hazard as Thread. The reporter's controlled delayed-hide experiment measured a 317-physical-pixel initial header offset; it does not establish the trigger for the original persistent offset. This PR does not claim that trigger is confirmed.

At this head: eight scoped mobile suites, 74/74 tests passed; mobile typecheck passed; Stack.tsx lint passed with one existing warning outside the added line. All commands exited 0. Linux x86_64, Node 24.21.0, Vite+ 1.3.0, Vitest 5.0.5, Oxlint 1.88.0, tsc-rs 7.1.0-dev. No native app, browser, or simulator was run. All 10 matrix rows are accounted for, including all eight affected Android runtime rows explicitly unverified.

No new regression test: 0 → 0. Source-text, option-value, and wiring assertions cannot establish native layout geometry. Eight existing navigation/draft suites are retained. Native Android rows remain unverified; the issue's VM exception permits scoped tests and typecheck instead of pixel captures. iOS runtime is also unverified.

Verification

What else changes: Android's transient “Switching branch...” placeholder also starts without the native title/header; leaving that placeholder is already guarded during checkout. Both missing-project and loaded draft paths retain their existing custom toolbar. iOS retains the inherited sheet header options and initial native header visibility. Web and desktop do not use this stack; no contracts, providers, server, data, or connection-mode behavior changes.

Evidence

Head: 268b1b075c. Comparison: ea1c49419e.

Two isolated read-only reviews (Codex GPT-6.1-Sol and Claude Opus 5.5) returned VERDICT: MERGE without confirmed findings at the current head. Proof-audit details are in the evidence links. Android verification is reserved for Julius; this PR is unmerged.

Model and harness: GPT-6.1-Sol through Codex in T3 Code; independent review by Claude Opus 5.5 through Claude Agent.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 21, 2026
@juliusmarminge
juliusmarminge marked this pull request as ready for review October 21, 2026 08:06
@macroscopeapp

macroscopeapp Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This one-line change alters Android's initial native-header default for the draft route, affecting first-layout product UI while leaving iOS and other routes unchanged. Because it changes a product default, human review is required.

Notes:

  • All code in this push has already been reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Team
  • Run ID: 738f9510-7931-47d0-8ce3-273143098af6
📥 Commits

Reviewing files that changed from the base of the PR and between 618761a and 268b1b0.

📒 Files selected for processing: 1
  • apps/mobile/src/Stack.tsx

Limit details: You’ve used all 10 included reviews currently available.

📝 Walkthrough

The NewTaskDraft route now hides its native header on Android. On other platforms, the route retains the native header.

Changes: Android NewTaskDraft header

Layer / File(s) Summary
Set platform-specific header visibility
apps/mobile/src/Stack.tsx
The NewTaskDraft route sets headerShown to Platform.OS !== "android".

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: maria-rcks

Merge Risk: ⚪ Minimal · up to 268b1

No actionable merge-blocking risk remains; the change is ready to merge.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly identifies the mobile Android fix and the specific initial-layout header issue.
Linked Issues check Passed Issue [#22737] requires NewTaskDraft.options.headerShown to initialize to Platform.OS !== "android". The whole-PR diff adds this exact option in apps/mobile/src/Stack.tsx. Existing `headerBackVi…
Out of Scope Changes check Passed The whole-PR diff contains one scoped change in apps/mobile/src/Stack.tsx. The change affects only NewTaskDraft route header initialization. It does not modify contracts, providers, server code, d…
Description check Passed The description includes all required sections: Problem, Change, Scope and approval, and Verification. It identifies the linked issue, explains the focused Android change, documents the approval basis…
Full details: Linked Issues check

Explanation

Issue [#22737] requires NewTaskDraft.options.headerShown to initialize to Platform.OS !== "android". The whole-PR diff adds this exact option in apps/mobile/src/Stack.tsx. Existing headerBackVisible and title options remain unchanged, so the custom toolbar and iOS behavior remain in scope. No separate automated test requirement is stated in the issue.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff contains one scoped change in apps/mobile/src/Stack.tsx. The change affects only NewTaskDraft route header initialization. It does not modify contracts, providers, server code, data behavior, or connection-mode behavior.

Full details: Description check

Explanation

The description includes all required sections: Problem, Change, Scope and approval, and Verification. It identifies the linked issue, explains the focused Android change, documents the approval basis, reports test results and limitations, and records unverified runtime checks. UI screenshots are not included, but the author clearly explains that no Android or iOS runtime was available.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@juliusmarminge juliusmarminge added the via-triage Filed through npx t3 triage label Oct 21, 2026
@juliusmarminge juliusmarminge added via-triage:needs-julius Triage fix: route gate or unverifiable surface needs Julius bugfix Fix PR opened by an issue lead; enters the PR loop pr:needs-julius Needs Julius: route gate, unverifiable surface, or blocked and removed via-triage Filed through npx t3 triage via-triage:needs-julius Triage fix: route gate or unverifiable surface needs Julius labels Oct 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fix PR opened by an issue lead; enters the PR loop pr:needs-julius Needs Julius: route gate, unverifiable surface, or blocked size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android NewTaskDraft initially reserves space for a native header it hides after mount

1 participant