Skip to content

fix(web): keep branchless thread cards full height - #25716

Open
PixPMusic wants to merge 1 commit into
pingdotgg:mainfrom
PixPMusic:fix/thread-row-height
Open

PixPMusic wants to merge 1 commit into
pingdotgg:mainfrom
PixPMusic:fix/thread-row-height

Conversation

@PixPMusic

Copy link
Copy Markdown
Contributor

Problem

In the New design, a local project thread without a branch shrinks to a 60 px card when its only remaining metadata is the provider icon. Neighboring cards with branches stay 78 px tall. Alex requested the larger, consistent card size.

Change

Keep the standard card height and metadata line, including the provider icon at the bottom. Remove the conditional compact height and its intrinsic-size override.

Scope and approval

Focused restoration of the existing sidebar card layout, requested by Alex. This qualifies as a small visual regression fix without a prior issue. Web and desktop share this component; native mobile has separate thread rows. Existing slim shelf rows retain their layout.

Related: #25605 proposes a broader one-line sidebar design and overlaps this component.

Verification

  • vp run check:changed passed formatting, lint, knip, and affected web/scripts typechecks.
  • Verified the real app against isolated demo data at 1280×850 in dark and light appearance: branchless cards change from 60 to 78 px; the branch card stays 78 px. The classic design also retains 78 px cards.
  • Matched dark-mode captures below are cropped to the sidebar. Demo fixtures and proof images are excluded from the commit. Electron was not separately launched. No cosmetic UI test added.
Before After
Before: branchless project cards collapse and move the provider icon beside the title After: all project cards keep the larger height and provider icon on the bottom line

Model: GPT-6.1 Sol (xhigh reasoning) | Harness: Codex in T3 Code

@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Oct 27, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at d9dc1af

Macroscope's review found this PR approvable — This focused web UI fix restores consistent full-height sidebar cards for branchless threads and keeps their provider metadata in the standard bottom row. It touches no data contracts, workflows, configuration defaults, or static-analysis settings.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between becf853 and d9dc1af.

Files selected for processing: 1
  • apps/web/src/components/sidebar/SidebarThreadRow.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Walkthrough

The sidebar thread row no longer changes its height or provider-stack placement when its metadata line lacks branch, machine, PR, diff, remote-environment, or terminal details.

Changes: Sidebar thread row layout

Layer / File(s) Summary
Row height and metadata placement
apps/web/src/components/sidebar/SidebarThreadRow.tsx
The row no longer computes whether its metadata line is empty or adjusts its height based on that condition. The provider stack remains in the metadata line, which is no longer conditionally hidden.

Priority: Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Possibly related PRs

Suggested labels: size:S

Suggested reviewers: t3dotgg

Merge Risk: Minimal · up to d9dc1

The branchless cards now retain the standard height and metadata placement, with no actionable merge-blocking risk identified.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely describes the primary fix: preserving full height for branchless thread cards.
Description check Passed The description includes all required sections. It explains the problem, change, scope, approval rationale, verification results, screenshots, limitations, and agent details.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant