[juliusmarminge]

Problem

ChatView kept a composerMountedRef plus a second layout effect that compared it with composerMounted and, on change, reset the three composer inset refs and re-published the overlay height. Its body was identical to the thread-switch reset effect. The ref also lagged: when ChatView mounted on a provider-subagent thread (composer not mounted), the reset and observer effects published with the ref's initial true, and the extra effect then reset and re-published in the same commit.

Change

• Delete composerMountedRef and the compare effect.
• publishComposerOverlayHeight reads composerMounted directly. It is called through useStableCallback, which updates in an insertion effect, so every layout effect (and child calls through onComposerOverlayHeightChange) already sees the current render's closure.
• The thread-switch reset effect also keys on composerMounted; its existing exhaustive-deps disable reason now covers composer mount/unmount. The resize-observer effect does not depend on composerMounted, so effect order within the commit is unchanged.

What this improves

• Simpler code: one layout effect, one ref and the previous-value bookkeeping removed.
• On mount with the composer hidden, or a thread switch that also flips the subagent bar, the overlay publishes once with the correct resting flag instead of publishing a stale value and then resetting and re-publishing.
• No bug fix is claimed: the final inset was already correct on main, so there is no regression test.

Behavior changes

None intended. The intermediate publish with the stale composerMounted: true flag no longer happens (it was immediately overwritten in the same commit).

Effects

• apps/web/src/components/ChatView.tsx: layout effects 3 -> 2 in this area (compare effect removed; reset and resize-observer effects kept, both measure DOM after commit).

Verification

• vp run check:changed: format, lint, knip 1/2, knip 2/2, typecheck (3 packages), test (2 files) all pass.

Model: Claude Opus 5.5, Claude Code harness.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This is a narrowly scoped composer measurement refactor with no schema or product-default changes. It also broadens a line-level oxlint diagnostic suppression, which requires human review under the applicable policy.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: effect/split-a2-chatview-composer-mounted
• File: .coderabbit.config.ts
• Commit: b673c52
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: a07c6089-1fe1-4ca2-a915-7c68d1f2ae37

Commits

Reviewing files that changed from the base of the PR and between 58c31f2 and b673c52.

Files selected for processing: 1

• apps/web/src/components/ChatView.tsx

Limit details: You’ve used all 10 included reviews currently available.

Walkthrough

The composer overlay measurement effect now responds to changes in composerMounted. The separate ref and layout effect that tracked those changes have been removed.

Changes: Composer Overlay Measurement

Layer / File(s)	Summary
Update overlay measurement apps/web/src/components/ChatView.tsx	publishComposerOverlayHeight now passes composerMounted to overlayComposerIsResting. The overlay measurement effect includes composerMounted as a dependency and handles the reset and measurement. The separate tracking ref and layout effect are removed.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Refactor

Suggested reviewers: t3dotgg, macroscopeapp

Merge Risk: Minimal · up to b673c

No actionable merge-blocking risk was identified in this focused refactor.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly describes the main change: consolidating composer overlay measurement into one layout effect.
Description check		The description explains the problem, change, effects, and verification. It does not include the required “Scope and approval” section or explain why the change qualifies for an exemption, but the res…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the problem, change, effects, and verification. It does not include the required “Scope and approval” section or explain why the change qualifies for an exemption, but the rest of the description is detailed and relevant.

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

• Mode: Continue automatically
• Reviewed files: 1
• Charged: $0.25
• View usage details

Note

This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing.

_{Comment @coderabbitai help to get the list of available commands.}