Skip to content

fix(build): keep effect out of the public-config bootstrap - #26371

Merged
juliusmarminge merged 1 commit into
mainfrom
t3/fix-main-eas-public-config
Oct 28, 2026
Merged

juliusmarminge merged 1 commit into
mainfrom
t3/fix-main-eas-public-config

Conversation

@juliusmarminge

Copy link
Copy Markdown
Member

Main has been red since https://git.cafe/pingdotgg/t3code/pulls/26350: it imported effect/Function into scripts/lib/public-config.ts. Mobile app.config.ts and apps/server/vite.config.ts load that file in the EAS production and production relay deploy jobs, whose installs do not resolve effect from the repo root. expo config --json exits 1 inside eas env:pull, so every EAS production job fails, and the relay deploy fails to load the server vite config.

Restores a dependency-free REPO_ROOT (NodePath.resolve(file, "../../.."), equivalent to three dirname calls). The file's header already says it runs before any Effect runtime exists.

Done with Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

#26350 imported effect/Function into scripts/lib/public-config.ts, which
mobile app.config.ts and the server vite config load in deploy jobs whose
installs do not resolve effect from the repo root. That broke every EAS
production job (expo config exits 1 in eas env:pull) and the production
relay deploy.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. labels Oct 28, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at bc51f1b

Macroscope's review found this PR approvable — Removes the Effect dependency from public-config bootstrapping while preserving repository-root resolution and environment loading. The change does not alter product defaults or broaden diagnostic suppressions.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 975b3dc and bc51f1b.

Files selected for processing: 1
  • scripts/lib/public-config.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

Walkthrough

The public configuration module now resolves REPO_ROOT with one NodePath.resolve call instead of three NodePath.dirname calls. It removes the pipe import. The public configuration interface and environment-loading behavior remain unchanged.

Changes: Public configuration

Layer / File(s) Summary
Repository root resolution
scripts/lib/public-config.ts
The module removes the pipe import and resolves REPO_ROOT with NodePath.resolve and "../../..".

Priority: High

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: t3dotgg

Merge Risk: Minimal · up to bc51f

No actionable merge-blocking risk remains.

Pre-merge checks: Passed 3 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the production failure and the dependency-free fix, but it does not provide explicit Scope and approval details or Verification results. Add the required Scope and approval section. Link the relevant issue or approval discussion, or explain why this focused bug fix qualifies without one. Add a Verification section with the commands or manual checks performed, their observed …
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly identifies the build fix and matches the main change: removing the Effect dependency from the public-config bootstrap.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Resolution

Add the required Scope and approval section. Link the relevant issue or approval discussion, or explain why this focused bug fix qualifies without one. Add a Verification section with the commands or manual checks performed, their observed results, and any checks that could not be run. State the agent model and harness at the end if applicable, using the required template structure and headings.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@juliusmarminge
juliusmarminge merged commit be2ea30 into main Oct 28, 2026
28 checks passed
@juliusmarminge
juliusmarminge deleted the t3/fix-main-eas-public-config branch October 28, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant