Repository navigation
fix(web): settling a thread no longer scrolls the sidebar to the bottom - #26392
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Sidebar focus restoration no longer scrolls after a moved row, while keyboard navigation retains its existing scroll behavior. The change is narrowly confined to UI focus handling. You can add or adjust custom eligibility rules. Learn more. |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settling a thread from the sidebar scrolled the sidebar all the way to the bottom. When the next thread opened it bounced back, or stayed stuck at the bottom with the new thread off-screen. This happened in boring mode and in the normal sidebar.
Clicking Settle focuses the row's button. The row then moves to the settled shelf at the bottom, and the button goes away. The sidebar tree puts focus back on the moved row (or the collapsed shelf header) and called
scrollIntoViewwhile doing it, which fought the route reveal that scrolls to the next thread. Restoring focus now usespreventScrolland does not scroll. Arrow-key navigation still scrolls.Proof: a new
sidebarTreebrowser test fails on main (scrollTop 341, expected 0) and passes with the fix. In the dev app with 30 threads, settling the open thread on main jumped scrollTop 0 → 490 (boring) and 0 → 1362 (normal) with the next thread off-screen; with the fix scrollTop stays 0 and the next thread is selected in place, in both modes.Reviewed with sol-loop: 1 round with GPT-6.1 Sol. Sol verdict: approved
Created with Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code