Skip to content

fix(web): settling a thread no longer scrolls the sidebar to the bottom - #26392

Merged
t3dotgg merged 1 commit into
mainfrom
t3/fix-sidebar-scroll-on-settle
Oct 28, 2026
Merged

t3dotgg merged 1 commit into
mainfrom
t3/fix-sidebar-scroll-on-settle

Conversation

@t3dotgg

@t3dotgg t3dotgg commented Oct 28, 2026

Copy link
Copy Markdown
Member

Settling a thread from the sidebar scrolled the sidebar all the way to the bottom. When the next thread opened it bounced back, or stayed stuck at the bottom with the new thread off-screen. This happened in boring mode and in the normal sidebar.

Clicking Settle focuses the row's button. The row then moves to the settled shelf at the bottom, and the button goes away. The sidebar tree puts focus back on the moved row (or the collapsed shelf header) and called scrollIntoView while doing it, which fought the route reveal that scrolls to the next thread. Restoring focus now uses preventScroll and does not scroll. Arrow-key navigation still scrolls.

Proof: a new sidebarTree browser test fails on main (scrollTop 341, expected 0) and passes with the fix. In the dev app with 30 threads, settling the open thread on main jumped scrollTop 0 → 490 (boring) and 0 → 1362 (normal) with the next thread off-screen; with the fix scrollTop stays 0 and the next thread is selected in place, in both modes.

Reviewed with sol-loop: 1 round with GPT-6.1 Sol. Sol verdict: approved

Created with Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 28, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at dd3b91c

Macroscope's review found this PR approvable — Sidebar focus restoration no longer scrolls after a moved row, while keyboard navigation retains its existing scroll behavior. The change is narrowly confined to UI focus handling.

You can add or adjust custom eligibility rules. Learn more.

@t3dotgg
t3dotgg merged commit 40d335a into main Oct 28, 2026
30 of 31 checks passed
@t3dotgg
t3dotgg deleted the t3/fix-sidebar-scroll-on-settle branch October 28, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant