Repository navigation
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Provider skill data apps/web/src/providerInstances.ts, apps/web/src/components/Sidebar.tsx |
ProviderInstanceEntry includes skills copied from provider snapshots. Provider-entry equality checks now compare skills references. |
Resolve and render sidebar skills apps/web/src/components/sidebar/SidebarThreadTitle.tsx, apps/web/src/components/sidebar/SidebarThreadTitle.test.tsx |
resolveSidebarSkills selects skills from the primary provider entry or instance map. SidebarThreadTitle renders recognized inline matches as chips and preserves unmatched text. Tests cover rendering and skill selection. |
Integrate skill titles in sidebar apps/web/src/components/sidebar/SidebarThreadRow.tsx, apps/web/src/components/ThreadHoverCard.tsx |
Hover cards, sidebar rows, and search results use SidebarThreadTitle with resolved skills. ThreadHoverCard accepts a ReactNode title. |
Priority:
Estimated code review effort: 2 (Simple) | ~12 minutes
Change: Feature
Sequence Diagram(s)
sequenceDiagram
participant ProviderSnapshot
participant deriveProviderInstanceEntries
participant SidebarThreadRow
participant resolveSidebarSkills
participant SidebarThreadTitle
ProviderSnapshot->>deriveProviderInstanceEntries: supply snapshot skills
deriveProviderInstanceEntries->>SidebarThreadRow: provide derived provider entries
SidebarThreadRow->>resolveSidebarSkills: resolve skills for the thread
resolveSidebarSkills->>SidebarThreadRow: return resolved skills
SidebarThreadRow->>SidebarThreadTitle: pass title and skills for rendering
Possibly related PRs
- pingdotgg/t3code#25432: Updates shared inline-skill matching and chat rendering used by this change to render sidebar skill badges.
Suggested reviewers: juliusmarminge
Merge Risk: 
Minimal · up to 22873
-
No merge-blocking issue was identified in the skill badge changes.
Pre-merge checks: 
3 · 
1
-
Failed checks: 1 warning Passed checks: 3 passedFull details: Description check
-
Explanation
The description explains the problem and implementation, but it omits the required Scope and approval section and does not provide focused verification results or UI screenshots. It also uses Summary and Changes instead of the template headings Problem and Change.
Resolution
Add the required Problem, Change, Scope and approval, and Verification sections. Include the related issue or maintainer approval, focused test commands with observed results, and before/after screenshots for the UI changes. State any checks that were not run.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Summary
Threads created with or referencing a skill (e.g.
$wayfinder 769) previously displayed plain text$skillin the sidebar list. In chat messages, skills are highlighted using purple cube skill chips (ContextChip). This change brings the same visual skill badges to sidebar thread row titles and search result rows.Changes
skills: snapshot.skillsinProviderInstanceEntryandSidebarProviderEntry, and compareother.skills !== entry.skillsinsameSidebarProviderEntries.matchInlineSkillsand renders visual skill chips (<ContextChip kind="skill">) with skill icon and formatted display name, while falling back to plain text for un-matched tokens or currencies.<span className="sr-only">{thread.title}</span>, and renaming mode continues to edit the raw title string.ReactNodefor title so hovering over thread rows also displays the formatted title with badge.apps/web/src/components/sidebar/SidebarThreadTitle.test.tsxcovering prefix badges, mid-title badges, currency immunity, unknown skills, and provider fallback resolution.