Repository navigation
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This change clarifies Antigravity model-access errors and adds provider-specific retry guidance. It preserves existing model-selection behavior and other providers’ fallback messaging. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Add guidance to ACP model rejections packages/provider-acp/src/server/adapter.ts |
AcpAdapterV2Flavor adds optional model-selection guidance. The adapter includes it in model rejection errors and uses the existing default instruction when it is absent. |
Supply and test Antigravity guidance apps/server/src/orchestration-v2/Adapters/AntigravityAdapterV2.ts, apps/server/src/provider/acp/AntigravityAcpSupport.ts, apps/server/src/orchestration-v2/Adapters/AntigravityAdapterV2.test.ts |
Antigravity supplies model-access instructions. Its unavailable-model message now refers to the ACP session. The adapter test checks the provider failure message and opens a session with another model. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Possibly related issues
- pingdotgg/t3code#19150 — The PR clarifies that ACP session model availability can differ from the Antigravity app, but does not change model discovery.
- pingdotgg/t3code#26738 — The PR explains that model access can depend on the sign-in method and ACP client, but does not change the model list.
- pingdotgg/t3code#26621 — The PR adds guidance to the explicit model rejection path; it does not change the silent-default path.
Possibly related PRs
- pingdotgg/t3code#26876 — Both PRs change Antigravity model rejection handling.
- pingdotgg/t3code#26623 — Both PRs address rejection of a selected model that is absent from the active ACP catalog.
- pingdotgg/t3code#25544 — Both PRs address Antigravity ACP session model availability.
Suggested labels: bugfix
Suggested reviewers: t3dotgg, stienswout
Merge Risk: 
Minimal · up to 7c14f
-
The change adds Antigravity-specific model-selection guidance. No merge-blocking issue was identified.
Pre-merge checks: 
4
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Usage-based review receipt
- Mode: Continue automatically
- Reviewed files: 2
- Charged: $0.50
- View usage details
Note
This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing.
CodeRabbit Verify
- Run CodeRabbit Verify to test the changes in this pull request.
…29-original # Conflicts: # apps/server/src/orchestration-v2/Adapters/AntigravityAdapterV2.test.ts
|
Note Written by updated the original branch at made guidance optional and moved the default into the error getter. main added another rejection constructor; requiring guidance there caused a type error and six existing catalog-rejection cases to fail. all six now pass. the final change remains four files, with 64 additions and 3 deletions. verification:
matching saved model and prompt, with the transient alert dismissed to show the complete persisted failure: current merge refresh: merged main blacksmith verification on this head: |
# Conflicts: # packages/provider-acp/src/server/adapter.ts


Problem
When Antigravity's ACP session does not offer a saved model, T3's error says only to choose another model. It does not explain why the same account can use that model in the Antigravity app. The local validation error also attributes the absence specifically to the Google account, although availability can depend on the ACP client and sign-in method.
The Claude discovery/access fix is already merged in #26876 and included in v0.1.5. The general fix that preserves model-rejection messages is already merged in #19699. This is a focused follow-up for the missing Antigravity-specific explanation reported in #16489 and #15378.
Change
Let an ACP adapter supply fixed model-rejection guidance. Antigravity explains the sign-in/client restriction and directs users to update T3, refresh models, and retry an offered model. Its local validation now describes availability in the ACP session rather than blaming the account.
Other adapters retain their existing message. The guidance is applied only at the existing model-write invalid-params boundary; native errors remain on
cause. Authentication and transport errors keep their handling. Model discovery, the client identity, and access rules are unchanged.Scope and approval
This qualifies for the small, focused obvious-bug exception in CONTRIBUTING.md: it corrects misleading error reporting for an existing integration. It does not attempt to change Google's restrictions or duplicate the already-merged access fix. The server produces the same diagnostic for web, desktop, mobile, and remote clients without contract changes.
Verification
960d5761c13f: the user-facing failure contained onlyThe agent did not accept the model "claude-test". Choose another model for this provider, then retry.vp run check:changed: formatting, lint, both knip passes, generated GraphQL, typechecks for 13 affected packages, and all 43 selected tests passed. Final verification also uses the repository's pinned Node 26.12.1.Runtime transcript using the real adapter and a local ACP fixture:
The fixture verifies T3's diagnostic and retry path, not Google's live authentication or model entitlement. No paid Claude turn or browser/mobile UI run was performed; macOS and Windows were not exercised locally. CI owns the full suites and builds.
Implemented and verified with GPT-6.1 Sol through the Codex harness in T3 Code.