Repository navigation
Conversation
Pin actions/checkout (v6), voidzero-dev/setup-vp (v1) and actions/cache (v6) to the commits those tags resolve to now. The setup-vp and cache SHAs are the ones setup-ci-deps and release-desktop.yml already pin. No version, input or permission changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Pin workflow action references .github/workflows/publish-aur.yml, .github/workflows/windows-tests.yml |
Both workflows replace version-tag action references with commit SHAs. The Windows test workflow’s behavior is otherwise unchanged. |
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Other
Suggested reviewers: macroscopeapp
Merge Risk: 
Minimal · up to cf7df
-
The workflows retain their existing behavior and use the intended action versions.
Pre-merge checks: 
4
-
Full details: Description check
-
Explanation
The description follows the required template. It explains the problem, the focused change, scope and approval rationale, verification results, and known limitations. It provides specific action pins, command results, and workflow evidence.
-
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Pins workflow actions to immutable commits verified to match their existing version tags. Publishing behavior, permissions, and test configuration remain unchanged while dependency reproducibility improves. You can add or adjust custom eligibility rules. Learn more. |
Problem
publish-aur.ymlrunsactions/checkout@v6in the job that also getsAUR_SSH_PRIVATE_KEY, the key that pushes the package every AUR user installs.windows-tests.ymlrunsactions/checkout@v6,voidzero-dev/setup-vp@v1andactions/cache@v6. All four are movable tags, so whoever controls those tags decides what code runs in these jobs. The release, signing and shared CI setup paths (release-desktop.yml,desktop-macos-preview*.yml,.github/actions/setup-ci-deps) already pin the same actions to commit SHAs. These two workflows were left on tags.Change
Each of the four
uses:lines now names the commit its tag resolves to today, with a# v6or# v1comment, as in #26305:actions/checkoutv6d23441a48e516b6c34aea4fa41551a30e30af803voidzero-dev/setup-vpv1250f29ce396baf5e8f24498e17c0dfdebabc26eb(same pin assetup-ci-deps)actions/cachev655cc8345863c7cc4c66a329aec7e433d2d1c52a9(same pin assetup-ci-depsandrelease-desktop.yml)No version, input, permission, runner or release logic changes. The jobs run the same action code they ran in their last runs.
Scope and approval
Maintenance with no product change, so no prior approval is linked. The scope is limited to these four uses in these two workflows. #5172 was closed asking for Actions changes to be reviewed one at a time, and this PR pins the existing versions instead of upgrading them. Other workflows still use tags; pinning them, or adding a pin check or Dependabot, would each be a separate PR if you want them.
Verification
git ls-remote https://github.com/<repo>.git refs/tags/<tag> 'refs/tags/<tag>^{}'for each action.checkoutv6andcachev6are lightweight tags on the commits above.setup-vpv1is an annotated tag that peels to250f29ce…. GitHub reports all three commits as verified.blacksmith-8vcpu-windows-2025, loggedactions/checkout@v6 (SHA:d23441a4…),voidzero-dev/setup-vp@v1 (SHA:250f29ce…)andactions/cache@v6 (SHA:55cc8345…). The AUR job in release run 41193999977 loggedactions/checkout@v6 (SHA:d23441a4…)and receivedAUR_SSH_PRIVATE_KEYin the same job.action.ymlat each pinned commit declares everywith:input these steps pass:sparse-checkout,sparse-checkout-cone-mode,node-version-file,cache,run-install,pathandkey.actionlint1.7.12 on both files reports only the existing unknown-label warnings for the Blacksmith runners, which base also reports.vp run check:changed 1d626d02d95f9a2343553f6498037ee82290d304passes: format, typecheck of 39 packages and 1 test file.Not checked: I did not run either workflow on this branch. Windows Tests runs on a Blacksmith runner, and the AUR job only runs in
pingdotgg/t3codewith the AUR key. The run logs above show these jobs already ran these exact commits.Prior PRs
Generated with Claude Opus 5.5 and GPT-6.1 Sol in T3 Code Nightly