[juliusmarminge]

main CI has been red since https://git.cafe/pingdotgg/t3code/pulls/29573 landed. That PR added a test expecting check:changed to lint an Astro file with ["lint", page]. https://git.cafe/pingdotgg/t3code/pulls/29596 landed just before it and made every lint call pass --no-error-on-unmatched-pattern. Each PR was green on its own base; together, the new Astro test fails on every commit since 8cebee4277.

The test now expects the flag, matching the neighbouring lint test. The test fails without this change and passes with it (vp test run scripts/check-changed.test.ts: 15/15).

Done by Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at c424ca5

Macroscope's review found this PR approvable — The change is confined to ignored paths and updates a test expectation for an existing lint flag. The supplied context indicates no product-default change or new diagnostic suppression.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The Astro-component launcher test now expects the lint command to include --no-error-on-unmatched-pattern before the changed page path.

Changes: Astro lint test

Layer / File(s)	Summary
Update Astro lint expectation scripts/check-changed.test.ts	The expected lint arguments now include --no-error-on-unmatched-pattern before the Astro page path.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Possibly related PRs

• pingdotgg/t3code#29573: Added the Astro check:changed test and .astro files to the CODE matcher.
• pingdotgg/t3code#29839: Makes the same test expectation change.
• pingdotgg/t3code#29596: Changed check:changed to pass --no-error-on-unmatched-pattern to lint.

Suggested labels: size:S

Suggested reviewers: saphid

Merge Risk: Minimal · up to c424c

No actionable merge-blocking risk was identified.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly identifies the test fix and the missing lint flag. It is concise and directly related to the changeset.
Description check		The description explains the problem, the change, and the verification command with its result. It does not use the required section headings or explicitly explain the scope exemption, but it provides…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the problem, the change, and the verification command with its result. It does not use the required section headings or explicitly explain the scope exemption, but it provides enough context for this small, focused fix.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ast-grep (0.51.1)

ast-grep could not parse rule config: /ast-grep-rules/ast-grep-essentials/rules/rust/security/reqwest-accept-invalid-rust.yml

CodeRabbit Verify

• Run CodeRabbit Verify to test the changes in this pull request.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: fix/check-changed-astro-lint-args
• File: .coderabbit.config.ts
• Commit: c424ca5
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: 276b4b60-8f20-4508-ad6c-45b0a5e86ab7

Commits

Reviewing files that changed from the base of the PR and between 30b9c4a and c424ca5.

Files selected for processing: 1

• scripts/check-changed.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

[juliusmarminge]

Superseded by https://git.cafe/pingdotgg/t3code/pulls/29839 (07846fc), which landed the same expectation fix on main first. Closing.