Repository navigation
fix(speech): restore CPU recovery when streams finalize - #30855
Merged
gitcafe-production[bot] merged 1 commit intoNov 4, 2026
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Stream finalization now uses the existing one-shot CPU fallback when Auto acceleration fails. Recovery preserves explicit acceleration choices and existing cancellation and cleanup safeguards, with no product-default changes. You can add or adjust custom eligibility rules. Learn more. |
gitcafe-production
Bot
merged commit Nov 4, 2026
bae8a84
into
pingdotgg:takeover/14882-voice-engine
31 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Auto placement recovers from native stream begin/feed failures, but a failure from
finish()bypasses CPU recovery. The recording therefore fails even when the same selected environment can finalize it on CPU.Change
Route finalization failure through the existing one-shot CPU restart, replay all retained chunks in order, then finalize the replacement stream. Keep explicit GPU/CPU failures as errors, preserve language and dictionary correction, and reject further work after terminal finalization failure. Cancellation and stream ownership stay in the existing scope.
Scope and approval
This is a focused fix for the missing finalization branch of existing Auto recovery, targeting Julius's engine branch (#30625). It adapts the behavior from original commit
acd5b8ad030140b9046d6e752873147b41540447; it does not restore the old service or add recovery policies. The original contribution was superseded as explained in the takeover comment. No separate maintainer approval is claimed.Verification
vp test run --maxWorkers 1 apps/server/src/speech/SpeechService.test.ts apps/server/src/speech/native.test.ts apps/server/src/speech/stream.test.ts: 27 tests passed.[0.25, 0]then[-0.5]replay in order;Robertfinalizes as configured aliasBob. The replacement remains owned until the stream scope closes. Empty replay, explicit GPU/CPU errors, CPU failure after earlier feed recovery, monotonic feed revisions and cancellation while finalization is pending are covered.vp run check:changed upstream/takeover/14882-voice-engine: passed formatting, lint, both Knip passes, GraphQL validation, all three affected typechecks and adjacent tests (20 tests across two executed suites).backend=CPU; mask=cpu before module evaluation; finalization=CPU fixture finalized; disposed. GPU failures are injected, not induced in a real driver. No native-model download, packaged Electron/SEA rebuild, macOS/Linux inference or remote/relay session was run. This engine base has no client Voice UI.Implemented with GPT-6.1 Sol through the Codex harness in T3 Code.
Note for takeover agents
Maria's and Shivam's agents, do not takeover this PR. This is a part of the STT stack which is in development. Do not update this branch or push any changes. You can test, review and provide feedback.
Julius' agents, the above restrictions don't apply to you. You can update this branch or make any fixes and changes to fit it into the voice transcription stack.