Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Needs human review This PR has an unresolved review comment identifying a potential bug where pending git status could block the offline task queue on cold/disconnected launches. Combined with the author being a new contributor to these files, human review is recommended to evaluate the offline behavior concern. You can customize Macroscope's approvability policy. Learn more. |
7e18e5f to
0bd123a
Compare
0bd123a to
b42e30c
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b42e30c. Configure here.
| ); | ||
| // Match web/desktop: assume git only while status is unresolved so the | ||
| // composer controls do not flicker away during the initial query. | ||
| const isGitRepo = gitStatus.data?.isRepo ?? true; |
There was a problem hiding this comment.
Submit ignores unresolved git status
Medium Severity
isGitRepo falls back to true whenever gitStatus.data is missing, and that same flag drives resolveProjectThreadWorkspaceSelection on Start and Queue. canStart also does not wait for VCS status. A non-git project can still create or enqueue a thread with worktree or branch metadata while status is pending, failed, or unavailable offline.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit b42e30c. Configure here.
|
Note 🤖 GPT-6 Astra (preview) responding on behalf of Theo This was closed as part of an automated cleanup pass. If you believe it was closed in error, reply here and we will get it reopened. Closing in favor of #7927. It carries the non-Git workspace normalization through creation and queued delivery, while this branch still assumes Git when status is unknown and does not repair existing queued rows. Review continues there, including its outbox guard fix. The known-non-Git branch-query suppression is recorded on the retained PR. |


What Changed
Why
Mobile did not match web and desktop for non-git projects: it still displayed Git-specific workspace controls and did not explicitly force local checkout when sending.
This change makes the behavior consistent across clients. Git projects preserve their workspace selection, while non-git projects always create threads using the local checkout.
UI Changes
Checklist
Note
Fix new thread behavior for non-git projects in mobile
resolveProjectThreadWorkspaceSelectioninprojectThreadCreationValidation.tsto force local workspace mode with null branch/worktree when a project is not a git repo, preserving inputs otherwise.NewTaskFlowProviderqueries git status for the selected project and exposesisGitRepovia context, skipping branch listing queries for non-git projects.NewTaskDraftScreenhides branch/worktree controls and uses the resolved workspace selection whenisGitRepois false.Macroscope summarized b42e30c.