Skip to content

Fixing the work of percy - #141

Merged
waralex merged 1 commit into
devfrom
percy_fix
Oct 25, 2021
Merged

waralex merged 1 commit into
devfrom
percy_fix

Conversation

@waralex

@waralex waralex commented Oct 24, 2021

Copy link
Copy Markdown
Contributor

Previously, the finalize --all of percy was triggered only when integration or unit tests failed. 🙈
I should have figured out the settings of percy and what we have written in circleci config much earlier 😢

@waralex
waralex requested a review from alexcjohnson October 24, 2021 12:23
@waralex waralex linked an issue Oct 24, 2021 that may be closed by this pull request

@alexcjohnson alexcjohnson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! 🙈 💃

@waralex
waralex merged commit aa3d51b into dev Oct 25, 2021
@alexcjohnson
alexcjohnson deleted the percy_fix branch October 25, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Percy config

2 participants