Wrong position for 3D Plot with more then one 3D plot in a Grid #413

Activity

1. kMutagene commented on Aug 30, 2023

   

   kMutagene

   on Aug 30, 2023

   Last edited by kMutagene

   Collaborator

   More actions

   Hey @Nick135, thanks for reporting this. I can confirm this as a regression that seems to occur somewhere between 3.0 and 4.0. It seems to be specific for adding multiple 3D charts to a grid, as a complex example with many different trace types works (see https://plotly.net/chart-layout/multiple-charts.html#Using-subplots-of-different-trace-types-in-a-grid). Adding a second 3D chart breaks the grid in that example.

   For now, a quick workaround would be falling back to pre 4.0 versions like this:

   #r "nuget: Plotly.NET, 3.0.0"
   #r "nuget: Plotly.NET.CSharp, 0.8.0"
   #r "nuget: Plotly.NET.Interactive, 3.0.0"

   

   👍React with 👍1Reacted by JE
2. Nick135 commented on Aug 31, 2023

   

   Nick135

   on Aug 31, 2023

   Author

   More actions

   When I add WithXAxisStyle to both 3D Plots, I also get the problem with the v3.0.

   #r "nuget: Plotly.NET, 3.0.0"
   #r "nuget: Plotly.NET.CSharp, 0.8.0"
   #r "nuget: Plotly.NET.Interactive, 3.0.0"
   
   
   using Plotly.NET.CSharp;
   
   var testData = new[]{1.0,1.1,2.0};
   
   var y = testData.Select(s=>s*-1).ToList();
   var s1 = Chart.Scatter3D<double, double, double, string>(
               x: testData,
               y: y,
               z: testData.Select(s=>s*1.2).ToList(),
               mode: Plotly.NET.StyleParam.Mode.Lines_Markers,
               Name: "Plot 1 - 3D"
           )
           .WithXAxisStyle<string, string, string>(TitleText: "x1", Id: Plotly.NET.StyleParam.SubPlotId.Scene.NewScene(1))
           .WithYAxisStyle<string, string, string>(TitleText: "y1", Id: Plotly.NET.StyleParam.SubPlotId.Scene.NewScene(1));
   var s2 = Chart.Point<double, double, string>(
               x: testData,
               y: y,
               Name: "Plot 2 - 2D"
           );
   var s3 = Chart.Scatter3D<double, double, double, string>(
               x: testData,
               y: y,
               z: testData.Select(s=>s*2.1).ToList(),
               mode: Plotly.NET.StyleParam.Mode.Lines_Markers,
               Name: "Plot 3 - 3D"
           )
           .WithXAxisStyle<string, string, string>(TitleText: "x2", Id: Plotly.NET.StyleParam.SubPlotId.Scene.NewScene(1))
           .WithYAxisStyle<string, string, string>(TitleText: "y2", Id: Plotly.NET.StyleParam.SubPlotId.Scene.NewScene(1));
   
   Chart.Grid(new[]{s1,s2,s3}, 3,1).Show();
   

   
3. bvenn commented on Aug 31, 2023

   

   bvenn

   on Aug 31, 2023

   Collaborator

   More actions

   Setting unique Axis ids seems to fix this behaviour.

   Details

   #r "nuget: Plotly.NET, 3.0.0"
   #r "nuget: Plotly.NET.CSharp, 0.8.0"
   #r "nuget: Plotly.NET.Interactive, 3.0.0"
   
   
   using Plotly.NET.CSharp;
   
   var testData = new[]{1.0,1.1,2.0};
   
   var y = testData.Select(s=>s*-1).ToList();
   var s1 = Chart.Scatter3D<double, double, double, string>(
               x: testData,
               y: y,
               z: testData.Select(s=>s*1.2).ToList(),
               mode: Plotly.NET.StyleParam.Mode.Lines_Markers,
               Name: "Plot 1 - 3D"
           )
           .WithXAxisStyle<string, string, string>(TitleText: "x1", Id: Plotly.NET.StyleParam.SubPlotId.Scene.NewScene(1))
           .WithYAxisStyle<string, string, string>(TitleText: "y1", Id: Plotly.NET.StyleParam.SubPlotId.Scene.NewScene(1));
   var s2 = Chart.Point<double, double, string>(
               x: testData,
               y: y,
               Name: "Plot 2 - 2D"
           );
   var s3 = Chart.Scatter3D<double, double, double, string>(
               x: testData,
               y: y,
               z: testData.Select(s=>s*2.1).ToList(),
               mode: Plotly.NET.StyleParam.Mode.Lines_Markers,
               Name: "Plot 3 - 3D"
           )
           .WithXAxisStyle<string, string, string>(TitleText: "x2", Id: Plotly.NET.StyleParam.SubPlotId.Scene.NewScene(2))
           .WithYAxisStyle<string, string, string>(TitleText: "y2", Id: Plotly.NET.StyleParam.SubPlotId.Scene.NewScene(2));
   
   Chart.Grid(new[]{s1,s2,s3}, 3,1).Show();

   
4. Nick135 commented on Aug 31, 2023

   

   Nick135

   on Aug 31, 2023

   Last edited by Nick135

   Author

   More actions

   @bvenn: It looks like it works, but when you see the second 3D Plot, the "TitleText" is not set.

   
5. kMutagene commented on Sep 4, 2023

   

   kMutagene

   on Sep 4, 2023

   Collaborator

   More actions

   The root of this bug must be the assignment of new scene ids to the existing charts. The internal logic of Chart.Grid combines all charts and adds new unique axis, scene, ternary, etc. positions and ids. Here is the match case for 3D charts:

   Plotly.NET/src/Plotly.NET/ChartAPI/Chart.fs

   Lines 3055 to 3067 in 11456b4

   	| TraceID.Cartesian3D ->
   	let scene =
   	layout.TryGetTypedValue<Scene> "scene"
   	|> Option.defaultValue (Scene.init ())
   	|> Scene.style (Domain = LayoutObjects.Domain.init (Row = rowIndex - 1, Column = colIndex - 1))
   	let sceneAnchor =
   	StyleParam.SubPlotId.Scene(i + 1)
   	gChart
   	|> GenericChart.mapTrace (fun t -> t :?> Trace3D |> Trace3DStyle.SetScene sceneAnchor :> Trace)
   	|> Chart.withScene (scene, (i + 1))

   so setting a scene id other than 1 here will cause the issue of the contained axis styles not being added to the new scene, the same is true for all other chart types btw. This is by design, checking for any possible scene id (or axis id etc.) adds gigantic overhead to an already very complicated and hard to maintain function.

   However, i cannot find striking differences in the code when e.g. comparing with the match case for Ternary traces;

   Plotly.NET/src/Plotly.NET/ChartAPI/Chart.fs

   Lines 3133 to 3148 in 11456b4

   	| TraceID.Ternary ->
   	let ternary =
   	layout.TryGetTypedValue<Ternary> "ternary"
   	|> Option.defaultValue (Ternary.init ())
   	|> Ternary.style (
   	Domain = LayoutObjects.Domain.init (Row = rowIndex - 1, Column = colIndex - 1)
   	)
   	let ternaryAnchor =
   	StyleParam.SubPlotId.Ternary(i + 1)
   	gChart
   	|> GenericChart.mapTrace (fun t ->
   	t :?> TraceTernary |> TraceTernaryStyle.SetTernary ternaryAnchor :> Trace)
   	|> Chart.withTernary (ternary, (i + 1)))

   which works fine:

   #r "nuget: Plotly.NET, 4.2.0"
   #r "nuget: Plotly.NET.Interactive, 4.2.0"
   #r "nuget: Plotly.NET.CSharp"
   
   
   using Plotly.NET.CSharp;
   
   var testData = new[]{1.0,1.1,2.0};
   
   var y = testData.Select(s=>s*-1).ToList();
   var s1 = Chart.ScatterTernary<double, double, double, double, string>(
               A: testData,
               B: y,
               C: testData.Select(s=>s*1.2).ToList(),
               Mode: Plotly.NET.StyleParam.Mode.Lines_Markers,
               Name: "Plot 1 - Ternary"
           );
   var s2 = Chart.Point<double, double, string>(
               x: testData,
               y: y,
               Name: "Plot 2 - 2D"
           );
   var s3 = Chart.ScatterTernary<double, double, double, double, string>(
               A: testData,
               B: y,
               C: testData.Select(s=>s*1.2).ToList(),
               Mode: Plotly.NET.StyleParam.Mode.Lines_Markers,
               Name: "Plot 3 - Ternary"
           );
   
   var g = Chart.Grid(new[]{s1,s2,s3}, 3,1);
   
   g

   
6. kMutagene commented on Sep 4, 2023

   

   kMutagene

   on Sep 4, 2023

   Collaborator

   More actions

   I found the core issue in the output at least. The row number for the scenes is incorrect, while it is correct in the ternary example:

   with Chart.Scatter3D:

   "scene":{
     "camera":{"projection":{"type":"perspective"}},
     "domain":{"row":2,"column":0} <-- row should be 0
   },
   "scene3":{
     "camera":{"projection":{"type":"perspective"}},
     "domain":{"row":2,"column":0}
   }

   with Chart.ScatterTernary:

   "ternary":{
     "domain":{"row":0,"column":0}
   },
   "ternary3":{
     "domain":{"row":2,"column":0}
   },

   which is really weird because at least to my eyes the code looks identical.
7. kMutagene

   added

   Type: Bug

   Area: Core API

   on Sep 4, 2023
8. kMutagene

   added this to the Plotly.NET 5.0 milestone on Sep 4, 2023
9. kMutagene commented on Sep 11, 2023

   

   kMutagene

   on Sep 11, 2023

   Collaborator

   More actions

   found the underlying issue, there are some fixes necessary that are deep in the low-level APIs, see #415 for details. This will be potentially backwards-incompatible and therefore be in v5.
10. kMutagene

    added a commit that references this issue on May 24, 2024

    fix #413:

    ...

    This issue will close once commit 66496cc is merged into the 'dev' branch.

    66496cc
11. kMutagene

    closed this as completedin #453on May 27, 2024