Violins and Boxes not always honoring 'group' #3390

Activity

1. nicolaskruchten

   added

   bugsomething brokensomething broken

   on Jan 3, 2019
2. etpinard commented on Jan 3, 2019

   

   etpinard

   on Jan 3, 2019

   Contributor

   More actions

   The last one is where the problem is: why are they overlaid?

   Would it be too much to ask to share the "data" / "layout" of that graph. I'm not too familiar with px (yet). Thanks!
3. nicolaskruchten commented on Jan 4, 2019

   

   nicolaskruchten

   on Jan 4, 2019

   ContributorAuthor

   More actions

   https://plot.ly/~nicolaskruchten/252
4. nicolaskruchten commented on Jan 4, 2019

   

   nicolaskruchten

   on Jan 4, 2019

   Last edited by nicolaskruchten

   ContributorAuthor

   More actions

   OK, so the reason it's not grouping is because of this block:

   plotly.js/src/traces/box/cross_trace_calc.js

   Lines 80 to 84 in 364cdec

   	// if there's no duplication of x points,
   	// disable 'group' mode by setting counter to 1
   	if(pointList.length === boxdv.vals.length) {
   	fullLayout[numKey] = 1;
   	}

   I'm not super clear on what it's doing or why but temporarily deleting that block does force things back into grouping mode, like it says in the comment. BUT I then get this odd behaviour, where it's grouping "too much"... it's like it doesn't think that the various "female" groups are the same and so it's leaving a bunch of extra room in each subplot :) ... split off into #3402

   

   😕React with 😕1Reacted by etpinard
5. nicolaskruchten commented on Jan 5, 2019

   

   nicolaskruchten

   on Jan 5, 2019

   ContributorAuthor

   More actions

   Maybe related? plotly/plotly.py#1389
6. nicolaskruchten commented on Jan 5, 2019

   

   nicolaskruchten

   on Jan 5, 2019

   Last edited by nicolaskruchten

   ContributorAuthor

   More actions

   Hmm actually the “too much grouping” is present in the first two screenshots as well, just less obviously-so. That might just be a separate issue. (see #3402)
7. nicolaskruchten

   changed the title [-]Violins and Boxes not honoring 'group'[/-] [+]Violins and Boxes not always honoring 'group'[/+] on Jan 5, 2019
8. etpinard

   self-assigned this

   on Jan 7, 2019
9. etpinard commented on Jan 16, 2019

   

   etpinard

   on Jan 16, 2019

   Last edited by etpinard

   Contributor

   More actions

   Consider the following:

   Plotly.newPlot('graph', [{
     type: 'box',
     x0: 1,
     y: [1,2,1,2,1,2,3,4,4],
   }, {
     type: 'box',
     x0: 2,
     y: [2,1,2,3,3,1,0,0,1]
   }], {
     boxmode: 'group'
   })
   

   which currently looks like:

   

   codepen: https://codepen.io/etpinard/pen/GPLXWX?editors=1010

   Now after 🔪 ing block

   plotly.js/src/traces/box/cross_trace_calc.js

   Lines 80 to 84 in 364cdec

   	// if there's no duplication of x points,
   	// disable 'group' mode by setting counter to 1
   	if(pointList.length === boxdv.vals.length) {
   	fullLayout[numKey] = 1;
   	}

   like it was proposed in #3390 (comment), we get

   

   ---

   In brief, currently we "disable" grouping when there are as many distinct box/violin positions as there are box/violin traces. One could argue that this piece of logic is too magical. Afterall, boxmode: 'overlay' by default: if we 🔪 boxmode in the above snippet, we get

   

   both on master and after 🔪 ing the aforementioned block that "disables" grouping.

   ---

   The case brought in https://plot.ly/~nicolaskruchten/252 is even more subtle. Here, there are as many distinct violin positions as there are violin traces on only one particular subplot (the bottom-left one, 1 violin position for 1 violin trace). So, this disables grouping for all subplots. This is obviously wrong: that check should happen at the graph-level, not the subplot-level. Fixing this would be easy.

   That said, instead of just fixing the above case, should we instead remove the magical disable-grouping block altogether?
10. nicolaskruchten commented on Jan 17, 2019

    

    nicolaskruchten

    on Jan 17, 2019

    ContributorAuthor

    More actions

    I would be fine with removing this magic, given that it can be turned on explicitly with overlay. This would cause further deviations from what bar does in group mode, however (which is basically to have the bars stretch to fill the available space, no matter how many there are).
11. etpinard commented on Jan 21, 2019

    

    etpinard

    on Jan 21, 2019

    Contributor

    More actions

    done in #3445
12. etpinard

    closed this as completedon Jan 21, 2019