Zoom doesn't work if not enough pixels are selected on X axis #4156

Activity

1. etpinard commented on Aug 29, 2019

   

   etpinard

   on Aug 29, 2019

   Contributor

   More actions

   Thanks for reporting!
2. etpinard

   added

   bugsomething brokensomething broken

   on Aug 29, 2019
3. etpinard commented on Sep 5, 2019

   

   etpinard

   on Sep 5, 2019

   Contributor

   More actions

   The problem is with the block:

   plotly.js/src/plots/cartesian/dragbox.js

   Lines 432 to 436 in b453045

   	// more strict than dragged, which allows you to come back to where you started
   	// and still count as dragged
   	if(Math.min(box.h, box.w) < MINDRAG * 2) {
   	return removeZoombox(gd);
   	}

   which removes the zoombox and skips the relayout call on drag-end when the zoombox width or height is less than 16px (as MINDRAG:=8).

   During drag, there's some logic around MINZOOM (set to 20px), but still, there are ways to have a zoombox passing MINZOOM requirements, but that have Math.min(box.h, box.w) < MINDRAG * 2, as reported in this issue.

   The easiest way to fix this bug, seems to simply move the problematic removeZoombox block from the zoomDone to the zoomMove handler.

   Alternatively, we could simply remove the problematic removeZoombox block, allowing for smaller zoom boxes relayouts. At first try, this doesn't appear to lead to any undesired effects.
4. etpinard

   self-assigned this

   on Sep 12, 2019
5. etpinard

   closed this as completedin #4188on Sep 13, 2019