Skip to content

Automargin edge cases - #3605

Merged
etpinard merged 6 commits into
masterfrom
automargin-edge-cases
Mar 5, 2019
Merged

Automargin edge cases#3605
etpinard merged 6 commits into
masterfrom
automargin-edge-cases

Conversation

@etpinard

@etpinard etpinard commented Mar 4, 2019

Copy link
Copy Markdown
Contributor

etpinard added 4 commits March 4, 2019 16:47
@etpinard
fix #3579 - consider tick labels to go past plot area
6c7db5e 
... in axis automargin computations. Add two mocks to lock this down!
@etpinard
improve axis automargin tests
1f6e711 
- start tests with margin:{l:0, t:0, r:0, b:0}
  to get more consistent result machine-to-machine
- add a few check to 🔒 #3579 even more
@etpinard
throw axis scaling error when ax._length is negative
8a1b5e7 
- which happens currently in #3600
- should make debugging easier
@etpinard
fix #3600 - skip automargin pushes that lead to negative plot area
87b10a7
@etpinard etpinard added bug something broken status: reviewable labels Mar 4, 2019
archmoj
archmoj reviewed Mar 5, 2019
View reviewed changes

@archmoj archmoj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etpinard thanks for the PR.
Please find my questions below.

Comment thread test/jasmine/tests/axes_test.js Outdated
Comment thread test/jasmine/tests/axes_test.js Outdated
Comment thread src/plots/plots.js Outdated
@etpinard etpinard mentioned this pull request Mar 5, 2019
Closed
@archmoj

archmoj commented Mar 5, 2019

Copy link
Copy Markdown
Contributor

💃
Nicely done @etpinard.

@etpinard
etpinard merged commit 1fd9560 into master Mar 5, 2019
@etpinard
etpinard deleted the automargin-edge-cases branch March 5, 2019 16:23
@wbrgss wbrgss mentioned this pull request Mar 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@archmoj archmoj archmoj left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug something broken

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clipped rotated tick labels with automargin

2 participants

@etpinard @archmoj