Repository navigation
Gate the jco-browser conformance target in CI; local opt-in - #39
Merged
Merged
Conversation
The Actions runner image ships Chrome (>=137, so JSPI is available), and the browser adapter's auto-detection already finds it — so the target gates in CI with zero setup. Locally it stays opt-in: the gate recipe runs the target under GitHub Actions or when CONFORMANCE_BROWSER=1, and skips with a notice otherwise (the conformance runner already warns rather than fails on a missing results file). The browser target runs before the runner pass, so one classification covers it; its manifests.toml expectations (ChaCha20-Poly1305 corpus, deterministic-ECDSA probe) were already written.
1 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Actions runner image ships Chrome (≥137, so JSPI is available with no flags), and the browser adapter's
findChrome()already probes/usr/bin/google-chrome— so the jco-browser conformance target gates in CI with zero new installs.conformancegains a_conformance-jco-browser-gatedep that runs the browser target under GitHub Actions, or locally when opted in withCONFORMANCE_BROWSER=1, and skips with a notice otherwise. It runs before the runner pass, so a single classification covers it; the runner's existing warn-on-missing-results behavior handles the local skip.Verified locally with
CONFORMANCE_BROWSER=1against a Playwright-cached Chromium: the target runs the full corpus and the runner classifies 0 fail / 0 unexpected-pass with all expected-fails matched. The skip path prints a notice and exits 0.