Repository navigation
docs(mock-adapter): correct permissions example for the mock instance API - #10
Open
woahwhattheheck wants to merge 3 commits into
Open
woahwhattheheck wants to merge 3 commits into
woahwhattheheck wants to merge 3 commits into
Conversation
… API TablePermissions reads the mock adapter AccessConf, not the global config, and takes five arguments. Example and explanation corrected; surrounding contribution preserved.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of @rafael81's open docs PR #3 at head
d449e12e.The permissions example configures global access settings and calls
TablePermissionswith three arguments. Current pREST reads the mock instance'sAccessConfand the method takes five arguments. This corrects the example (adapter.AccessConf, five-arg call) and its explanation while preserving the rest of the contribution. Refs prest/prest#284.Verification: postimage
get-prest/mock-adapter.mdreconstructed from the pinned preimage blob1984d67eat the donor head; patch is four hunks. No runtime execution performed.Attribution: builds on rafael81's documentation contribution; their authorship and any existing claim are preserved.
Compensation request
Please register this continuation under prest/prest#284's advertised IssueHunt funding for whatever scope the maintainers award; acceptance and payment per IssueHunt's ordinary process.