Repository navigation
Conversation
JSON.fast_generate was removed in version 3. It's no longer faster.
|
Do you understand why CI failing? I don't. |
|
The failing seems to be related to changes between rbs 3 and 4. UPDATE: I have updated the fixtures to what rbs 4 expects. Seems to work with rbs 3 as well. |
|
Hey, @kddnewton. This gem is a central piece of our current pipeline. Having this change would allow us to change from json 2 to 3 in the whole org (https://github.com/ivx). Saying this to tell you that your work is used everyday and is a valuable piece of our system. Thanks for the work. So we are very happy if you find the time to look at this again, but no hurries. |
Bump Ruby 4.0.6 -> 4.0.7, bundler to 4.0.21, gem dependencies (bunny, rubocop, simplecov, etc). Pin json < 3 in the test group -- 3.0 removed JSON.fast_generate, which @prettier/plugin-ruby's vendored server.rb still calls; remove once prettier/plugin-ruby#1468 ships. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
minitest resolved to version 6 in Ruby 3.2, which extracted minitest/mock into the minitest-mock gem.
|
@kddnewton Thanks for maintaining this project. We're in a similar spot to @ahx, and hoping to adopt this PR's fix. Totally understand that time is limited, but I was hoping you could share a timeline around when this PR might get reviewed / released. |
JSON.fast_generate was removed in version 3. It's no longer faster.
Solves #1467