Repository navigation
fix: respect preserveAspectRatio meet alignment in SVG use - #9292
Merged
davepagurek merged 2 commits intoOct 15, 2026
Merged
davepagurek merged 2 commits into
davepagurek merged 2 commits into
Conversation
Continuous ReleaseCDN linkPublished PackagesCommit hash: a160273 Previous deploymentsThis is an automated message. |
davepagurek
reviewed
Oct 15, 2026
davepagurek
left a comment
Contributor
There was a problem hiding this comment.
Looks great, thanks for completing our support of this property!
| // Default SVG alignment is xMidYMid meet. | ||
| const alignment = preserveAspectRatio?.trim().split(/\s+/)[0] || "xMidYMid"; | ||
|
|
||
| const alignX = alignment.startsWith("xMin") ? 0 |
Contributor
Author
There was a problem hiding this comment.
Thanks, Dave! I appreciate your review and feedback. It was a great opportunity to build on the previous SVG importer fix and improve the alignment support in p5.js!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9287.
The SVG importer previously centered
<symbol>content referenced by<use>, regardless of the specifiedpreserveAspectRatioalignment.This PR implements all nine meet alignment combinations (
xMin,xMid,xMax × YMin,YMid,YMax) while preserving the existing behavior forpreserveAspectRatio="none"and the defaultxMidYMid meet.Changes
preserveAspectRatio.viewBoxorigins.Testing
npm run lint: 0 errors, 18 warnings in existing code.Scope
This PR focuses on meet alignment behavior. Support for
sliceis outside the scope of this change and can be addressed separately.npm run lintpasses