test(cli): stop the pidfile zombie test racing the shell's reaper - #259
Merged
Merged
Conversation
`sh -c 'true & ...; exec sleep 30'` only leaves a zombie if `true` exits after the exec. When it exits first, sh reaps it and /proc/<pid>/stat is gone, so the poll threw ENOENT (failed twice in a row on #255's CI). Background a short sleep instead so the child outlives the exec, tolerate a missing stat file while polling, and assert the zombie state was reached. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ThreatCrush Security Scan16 finding(s) HIGH/CRITICAL: 1 | MEDIUM: 7 | LOW: 8
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isProcessAlive on a zombiespawnedsh -c 'true & echo $!; exec sleep 30'. Iftrueexits before the exec, sh reaps it and/proc/<pid>/statdisappears, so the poll throws ENOENT. It failed twice in a row on #255.sleep 0.5so the child exits after the shell has exec'd into a process that never waitsisProcessAliveRan the file 8 times locally: 8/8 pass.
🤖 Generated with Claude Code