Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes vsetvl vtype decoding/legality by validating the full XLEN-wide vtype encoding instead of only the low 8 bits, and by marking unsupported encodings as illegal via vill.
Changes:
- Treat any nonzero reserved
vtypebits ([XLEN-2:8]) as illegal by folding them intovillduring CSR decoding. - For
vsetvl, consume the fullrs2(XLEN bits) when updatingvtype, and explicitly rejectvill/illegal combinations when computing the newvl. - Document the fix in the changelog.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| hardware/src/ara_dispatcher.sv | Validates full-XLEN vtype for vsetvl and forces vill on unsupported encodings. |
| CHANGELOG.md | Notes the vsetvl/vtype validation fix under “Fixed”. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
I tested flaviens's candidate on official Ara main The test covers individual rs2 bits 8 through 63, two legal register controls, saved VILL restoration, and seven immediate cases. The public test names have been updated. I rebuilt the test and ran the same new ELF on both RTL versions, with two lanes and VLEN=2048. Real official The branch keeps the candidate and test together. I have not opened a duplicate PR. |
vsetvlignoredvtypebits above bit 7. Check the full XLEN value. Setvillfor unsupported encodings.Verification: Verilator elaboration.