Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes CSR clear-mask handling for vxrm by using the correct 2-bit vxrm_t type during mask construction, ensuring both vxrm bits are preserved/cleared as intended during CSR clear operations.
Changes:
- Update
CSR_VXRMclear-mask casting tovxrm_t(instead ofvxsat_e) so the mask remains 2 bits wide. - Update
CSR_VCSRclear-mask casting for the embeddedvxrmfield tovxrm_t. - Document the fix in the changelog.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| hardware/src/ara_dispatcher.sv | Fixes vxrm CSR clear-mask type casting to preserve both vxrm bits in clear operations. |
| CHANGELOG.md | Adds a “Fixed” entry describing the vxrm clear-mask correction. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
I tested flaviens's candidate on official Ara main The test seeds VCSR with immediate writes, then checks VXRM/VCSR clear masks through GPR and immediate forms. The same ELF runs on both RTL versions, with two lanes and VLEN=2048. Real official The branch keeps the candidate and test together. I have not opened a duplicate PR. |
The clear mask for
vxrmwas cast to one bit. Keep both mask bits.Verification: Verilator elaboration.