Skip to content

Don't count the padding in the indices of rolling argmin/argmax - #11696

Merged
headtr1ck merged 4 commits into
pydata:mainfrom
headtr1ck:rolling-argmax-padding
Oct 11, 2026
Merged

headtr1ck merged 4 commits into
pydata:mainfrom
headtr1ck:rolling-argmax-padding

Conversation

@headtr1ck

Copy link
Copy Markdown
Collaborator

Rolling argmin/argmax return the position within the padded window, so windows that extend beyond the array count the padding. This is most visible for cumulative, whose windows span the whole dimension: da.cumulative("time").argmax() returned [4, 4, 3, 4, 4] instead of [0, 1, 1, 3, 4] for [1, 2, 1.5, 3.5, 4].

Supersedes #11412.

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested any AI-generated content in my PR.
    • I take responsibility for any AI-generated content in my PR.
      Tools: Claude Code

[This is Claude Code on behalf of Michael Niklas]

🤖 Generated with Claude Code

Co-authored-by: Claude <noreply@anthropic.com>
@headtr1ck
headtr1ck marked this pull request as ready for review October 9, 2026 07:42
@headtr1ck headtr1ck mentioned this pull request Oct 9, 2026
3 tasks done
@headtr1ck headtr1ck added the plan to merge Final call for comments label Oct 10, 2026
@headtr1ck
headtr1ck enabled auto-merge (squash) October 11, 2026 15:00
@headtr1ck
headtr1ck merged commit 25ef02e into pydata:main Oct 11, 2026
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plan to merge Final call for comments topic-rolling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cumulate+argmax uses padded index instead of absolute index

1 participant