Repository navigation
Add DataArray.pad, Dataset.pad, Variable.pad - #3596
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello all,
This is my first PR to a pydata project. This pull request is still very much a work in progress and I could really use your input on a couple of things.
black . && mypy . && flake8whats-new.rstfor all changes andapi.rstfor new API**pad_width_kwargs. I chose the signature that I thought looked least awkward.mode=constantpads with NaN's converting the array to float in the process. This goes against the default behaviour of numpy as dask.Dataset.pad is coming up.