Skip to content

ConnectionPool polite close() call? #120

Closed
Closed
ConnectionPool polite close() call?#120
Labels
enhancement

Description

@smferguson
smferguson
opened on Apr 27, 2016

Hey guys,
We're beginning use of happybase and will be rolling it into prod in the coming weeks.
I'm curious why the connectionpool doesn't have a polite close() call.
I have code locally that loops over the pool and tries to close the connections, but I feel like there may be context (history) I'm missing.
Thanks,
Scott

Activity

  1. wbolster commented on Apr 27, 2016

    @wbolster
    wbolster
    on Apr 27, 2016
    Member

    No, there isn't any history or other context. A simple loop should do the trick indeed, perhaps it makes sense to have it in Happybase itself.

  2. smferguson commented on Apr 27, 2016

    @smferguson
    smferguson
    on Apr 27, 2016
    Author

    Cool. I'll submit a PR. Thanks for the quick reply.

  3. wbolster
    added
    enhancement
    and removed
    enhancement
    on May 16, 2017

  4. aisk commented on Oct 4, 2026

    @aisk
    aisk
    on Oct 4, 2026
    Contributor

    This is a duplicate of #229, which was been closed by #266. I think we can close it now.

  5. wbolster
    closed this as completedon Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancement

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions