Add DiagnosticTag tags for pylint, pycodestyle, and flake8 #144

Activity

1. krassowski

   changed the title [-]Add `DiagnosticTag` tags for pylint, pycodestyle[/-] [+]Add `DiagnosticTag` tags for pylint, pycodestyle, and flake8[/+] on Dec 31, 2021
2. ccordoba12 commented on Dec 31, 2021

   

   ccordoba12

   on Dec 31, 2021

   Member

   More actions

   Could you post an example of a reply that includes the tag?
3. krassowski commented on Dec 31, 2021

   

   krassowski

   on Dec 31, 2021

   MemberAuthor

   More actions

   /**
    * @deprecated
    */
   function oldFunc(test) { 
       return;
       let x = 1;
   }
   oldFunc

   {
       "uri": "javascript_test.js",
       "diagnostics": [
           {
               "range": {
                   "start": {
                       "line": 3,
                       "character": 17
                   },
                   "end": {
                       "line": 3,
                       "character": 21
                   }
               },
               "message": "'test' is declared but its value is never read.",
               "severity": 4,
               "code": 6133,
               "source": "typescript",
               "tags": [
                   1
               ]
           },
           {
               "range": {
                   "start": {
                       "line": 5,
                       "character": 4
                   },
                   "end": {
                       "line": 5,
                       "character": 14
                   }
               },
               "message": "Unreachable code detected.",
               "severity": 4,
               "code": 7027,
               "source": "typescript",
               "tags": [
                   1
               ]
           },
           {
               "range": {
                   "start": {
                       "line": 5,
                       "character": 8
                   },
                   "end": {
                       "line": 5,
                       "character": 9
                   }
               },
               "message": "'x' is declared but its value is never read.",
               "severity": 4,
               "code": 6133,
               "source": "typescript",
               "tags": [
                   1
               ]
           },
           {
               "range": {
                   "start": {
                       "line": 7,
                       "character": 0
                   },
                   "end": {
                       "line": 7,
                       "character": 7
                   }
               },
               "message": "'oldFunc' is deprecated",
               "severity": 4,
               "code": 6385,
               "source": "typescript",
               "tags": [
                   2
               ]
           }
       ]
   }

   I'm rendering it as:

   

   because:

   export namespace DiagnosticTag {
   	/**
   	 * Unused or unnecessary code.
   	 *
   	 * Clients are allowed to render diagnostics with this tag faded out
   	 * instead of having an error squiggle.
   	 */
   	export const Unnecessary: 1 = 1;
   	/**
   	 * Deprecated or obsolete code.
   	 *
   	 * Clients are allowed to rendered diagnostics with this tag strike through.
   	 */
   	export const Deprecated: 2 = 2;
   }
   
4. ccordoba12 commented on Jan 3, 2022

   

   ccordoba12

   on Jan 3, 2022

   Member

   More actions

   Ok, I see. Then it's just extra metadata in the request. Then I'm fine with your proposal.
5. ccordoba12

   closed this as completedin #229on Jun 30, 2022
6. ccordoba12

   added this to the v1.5.0 milestone on Jun 30, 2022