Add .flake8 to the discovery paths #219

Activity

1. ccordoba12 commented on Jun 14, 2022

   

   ccordoba12

   on Jun 14, 2022

   Member

   More actions

   Probably because the author of the flake8 plugin forgot to do it. But you're welcome to send us a pull request to add support for it.
2. m0wer commented on Jun 14, 2022

   

   m0wer

   on Jun 14, 2022 via email

   Author

   More actions

   Is `flake8` who handles the discovery of its configuration or does `python-lsp-server` do it instead? I'm a bit confused because the README lists the files that are considewred as if `python-lsp-server` handled the discovery. `flake8` already looks for `.flake8` so nothing to do there. If something needs to change in `python-lsp-server` to discover `.flake8` then I'll happily create a MR for that. Cheers.

   …

   On Tue, Jun 14, 2022 at 06:14:58AM -0700, Carlos Cordoba wrote: Probably because the author of the flake8 plugin forgot to do it. But you're welcome to send us a pull request to add support for it. -- Reply to this email directly or view it on GitHub: #219 (comment) You are receiving this because you authored the thread. Message ID: ***@***.***>
3. ccordoba12 commented on Jun 14, 2022

   

   ccordoba12

   on Jun 14, 2022

   Member

   More actions

   The server does the discovery.
4. lcheylus commented on Jun 28, 2022

   

   lcheylus

   on Jun 28, 2022

   Last edited by lcheylus

   Contributor

   More actions

   The documentation about Flake8 plugin is wrong : according to pylsp/config/flake8_conf.py, Flake8 configuration is looked for in .flake8, setup.cfg and tox.ini :

   CONFIG_KEY = 'flake8'
   PROJECT_CONFIGS = ['.flake8', 'setup.cfg', 'tox.ini']
   

   Moreover Flake8 4.0 does not read anymore its configuration in ~/.config/flake8 but only in .flake8, setup.cfg and tox.ini in a project directory (see https://flake8.pycqa.org/en/latest/user/configuration.html).
5. lcheylus

   added 2 commits that reference this issue on Jun 29, 2022

   Fix documentation for location of Flake8 configuration files

   ...

   This issue will close once commit 704f9ef is merged into the 'develop' branch.

   704f9ef

   Fix documentation for location of Flake8 configuration files

   ...

   This issue will close once commit 07dcb44 is merged into the 'develop' branch.

   07dcb44
6. ccordoba12

   added this to the v1.5.0 milestone on Jun 30, 2022
7. ccordoba12

   closed this as completedin #233on Jun 30, 2022
8. ccordoba12

   added a commit that references this issue on Jun 30, 2022

   Fix documentation for location of Flake8 configuration files (#233)

   ...

   This issue will close once commit c78a4c5 is merged into the 'develop' branch.

   c78a4c5