Repository navigation
Move to using package_data to install typeshed and xml files. #4143
Description
Currently, we use data_files to distribute typeshed and xml files. The prefix under which data_files is installed is not exposed publicly, which has lead to complexities and issues with resolving typeshed's install location such as #4142.
Therefore, I propose we move to package_data. This will install typeshed and the xml files into site-packages/mypy/typeshed and site-packages/mypy/xml. This will be much easier to find, and should avoid all of the intricacies in resolving the system prefix.
Activity
emmatyping commentedon Oct 26, 2017
Well, annoyingly, it appears this won't be possible, unless we require
pip install .to use admin on Windows (see pypa/pip#1006).However,
python3 setup.py installwill work fine, as well assdist,bdist_wheel, and just about any other installation I can think of (including oddlypip install -e ., which is a developer install). The underlying issue is typeshed symlinks, so we could fix that and everything would work, but Im not sure the path forward on that is the clearest to me.JelleZijlstra commentedon Oct 26, 2017
Wasn't that issue fixed in pypa/pip#1311?
emmatyping commentedon Oct 26, 2017
It was fixed, but it seems that the fix requires administrator access on Windows see pypa/pip#1311 (comment)
I tested it myself and it fails without privileges.
JukkaL commentedon Oct 26, 2017
I think that we should get rid of typeshed symlinks.
emmatyping commentedon Jul 3, 2018
Closing in favor of #5307