Repository navigation
Use replace-buffer-contents and remove cruft - #19
Merged
Merged
Conversation
Contributor
|
Thanks! Make sense. |
|
@pmiddend thanks for the contrib, just wondering, what version of emacs are you using? The reason I ask is because Version: GNU Emacs 25.2.2
|
Member
|
|
Member
|
It may be a good idea to replace most of this package with https://github.com/purcell/reformatter.el |
Contributor
|
@pmiddend Could you provide patch compatible with earlier Emacs versions? |
Contributor
Author
|
@proofit404 I'm afraid I can't since I'm not an elisp guru and I have no setup to test older emacs versions. Sorry :( |
proofit404
added a commit
that referenced
this pull request
Mar 1, 2019
This reverts commit e106f49.
proofit404
added a commit
that referenced
this pull request
Mar 1, 2019
Contributor
|
I need to revert this, unfortunately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/u/_noctuidtold me in (https://www.reddit.com/r/emacs/comments/at1f7h/elisp_apply_patch_to_buffer/)[this reddit thread] thatreplace-buffer-contentsis a better choice for replacing buffers in emacs. It seems to work, and doesn't need theoriginal-*variables.