Repository navigation
Move QASM 2 printing into its own module - #454
Conversation
Signed-off-by: Daniel Gaskins <danielgaskins99@gmail.com>
Argus reviewAuto-review is off for this repo. Tick the box below to run a review on this PR.
Estimated cost
Tip: you can also comment |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Thanks for the refactor @danielgaskins! While the idea is correct, I personally think that keeping Can you please move all the code that you have developed in You will also need to update the references to the |
|
Opened the drawing-module rename separately, as requested. Once it lands, I'll move the QASM printer into |
|
@danielgaskins I have approved your pull request for moving the printer into visualization. Can you please edit this PR accordingly? Thanks! |
Signed-off-by: Daniel Gaskins <danielgaskins99@gmail.com>
|
Moved the QASM printer to |
TheGupta2012
left a comment
There was a problem hiding this comment.
Thanks @danielgaskins, for your work on this! The changes lgtm.
Summary of changes
Moves
Qasm2Printerand conditional-branch normalization intopyqasm/printer.py, leavingqasm2.pyfocused on program handling. Validation and printing share the same normalization, and normalized branches have named fields.The drawing-module rename from #461 is now on main. Drawing stays in
pyqasm.visualization, withpyqasm.drawunchanged. This PR adds a changelog entry for the QASM printer refactor; the drawing API entry is already upstream.Closes #447.
All 1,033 tests pass with three existing skips. Before/after comparisons match exactly for output and error messages across 16 branch and transformation cases. Black, isort, Pylint, mypy, license headers and the Sphinx build with warnings treated as errors pass. Wheel and source-archive contents are checked, and a wheel smoke check covers imports, conditional validation and printing.