Mock selenium - #2
Merged
Merged
Conversation
podtserkovskiy
commented
Jun 7, 2017
Member
- мок селениума
- выбор реализации сторожа из кончика
- фиксы дедлоков
- улучшение описания ошибок
- добавление индексов
added 4 commits
June 7, 2017 18:37
- выбор реализации сторожа из кончика - фиксы дедлоков - улучшение описания ошибок
andrskom
reviewed
Jun 7, 2017
| @@ -0,0 +1,44 @@ | |||
| package main | |||
Member
There was a problem hiding this comment.
Лучше написать интерфейс инициализации и реализовать фабрику, мне кажется так будет правильнее. У тебя же есть DAL, так вот, от него и пляши.
Member
Author
There was a problem hiding this comment.
Давай так и сделаем
andrskom
requested changes
Jun 7, 2017
| "github.com/rubenv/sql-migrate" | ||
| ) | ||
|
|
||
| func invokeStorage(config config.Config) (storage pool.StorageInterface, err error) { |
Member
There was a problem hiding this comment.
Тут интерфейс наверно не совсем правильный.
Member
Author
There was a problem hiding this comment.
Ты о том что должен возвращаться StorageFactoryInterface? или я не правильно понял смысл коммента?
| @@ -0,0 +1,265 @@ | |||
| package main | |||
Member
There was a problem hiding this comment.
Перенеси в папочку utils и не забывай про комментарии.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.