Repository navigation
docs: document Parquet and CSV download options in the Result Grid - #484
Merged
javier merged 3 commits intoAug 3, 2026
Merged
Conversation
javier
approved these changes
Aug 3, 2026
Collaborator
|
Thanks! Sorry it took me a while to review |
javier
added a commit
that referenced
this pull request
Aug 14, 2026
…it (#493) ## Summary Fork PR previews stopped working because `actions/checkout` now refuses to check out fork code under `pull_request_target` (it runs with the base repo's secrets, a "pwn request" risk). This splits the preview into a build stage that never sees secrets and a trusted deploy stage that only handles the built artifact. - **`preview.yml`** now runs on `pull_request` with **no secrets**. The `PR preview` and `Validate broken links` jobs (unchanged names, so branch protection is unaffected) build the site; `PR preview` uploads the result as an artifact. Safe to run on fork code. - **`preview-deploy.yml`** (new) runs on `workflow_run`, downloads the artifact, and deploys to Netlify with the secrets. It never checks out or executes PR code. Same-repo PRs preview automatically; fork PRs preview only when the `preview` label is present, preserving current policy. - Bumped `checkout`/`setup-node` to v4 and used `upload/download-artifact@v4`. ## Notes - Because `workflow_run` always runs the workflow copy on the default branch, the deploy path only activates once this is merged to `main`; it cannot be exercised by this PR's own checks. The first end-to-end run is the next fork PR (e.g. re-triggering #484). - No new secrets or repository settings are required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the Result Grid download action to document both the Parquet and CSV export options.
Why
Addresses #305. The Result Grid docs only mentioned CSV, but the current Web Console shows Parquet as the primary download button and moves CSV into a dropdown.
Verified against the Web Console E2E tests (
questdb/ui,e2e/tests/console/download.spec.js):download-parquet-buttonis shown directly and requestsfmt=parquetdownload-csv-buttonappears underdownload-dropdown-buttonand requestsfmt=csvSo the previous single "Download result as CSV" bullet was both incomplete and out of date. This lists Parquet as the primary download and notes CSV is available from the dropdown, linking to the Parquet export page.
Scope
Covers the Parquet part of #305. The "views" note in that issue is left out, since the web-console views UI isn't documented yet ("will also soon need").
Testing
Docs-only change; the linked
/docs/query/export-parquet/page exists, so the Docusaurus broken-link build passes.