Repository navigation
ci(coil): desktop tests no longer race Electron's download - #195
Merged
Merged
Conversation
Electron downloads its binary the first time something imports it. The
fork's Test job never fetched it up front, so two desktop test files could
start that download at once and collide ("File exists"); the loser failed
with "Electron failed to install correctly". It failed main's CI run for
238aed8 on DesktopUpdates.test.ts after passing twice on the PR.
Run ensure:electron before the tests, as upstream's ci.yml, the release and
the weekly verify already do, and in the daily sync's test verify too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main's CI no longer fails at random on desktop tests.Electron downloads its binary the first time something imports it, and the fork's
Testjob never fetched it up front. Two desktop test files can start that download together and collide ("File exists"); the loser fails with "Electron failed to install correctly". That failedmain's CI for238aed8c8fonDesktopUpdates.test.ts, after the same tree passed twice on #193.The
Testjob and the daily sync's test step now runensure:electronfirst, as upstream'sci.yml,coil-release.ymlandcoil-weekly-verify.ymlalready do.Tests
Testjob then logged no "Downloading Electron binary", wheremain's failed run logged it twice. All 9 checks pass.bash -n scripts/coil/sync-upstream.shpasses, andcoil-ci.ymlparses as YAML.Merge danger
Low, two-way door. If the step fails, the
Testjob fails before running tests.Merge only after the release for
238aed8c8fpublishes, so that release stays marked latest.Made by Claude Opus 5.5 in Claude Code, driven from T3 Code.
🤖 Generated with Claude Code