Skip to content

Add CodeMirror commenting addon and Sublime keymap - #58

Closed
JasonSooter wants to merge 1 commit into
ramda:masterfrom
JasonSooter:master
Closed

JasonSooter wants to merge 1 commit into
ramda:masterfrom
JasonSooter:master

Conversation

@JasonSooter

Copy link
Copy Markdown

** DO NOT MERGE YET **

@CrossEye

This PR is in reference to issue

This is to add the functionality to comment code (line/block) within the REPL.

I imported the comment addon from CodeMirror along with the Sublime keymap that will enable commenting of code with CMD/CTRL + /.

I have been unable to get the functionality to work, however. I used the graphql/graphiql REPL as a guide as it uses CodeMirror in a similar style and has the commenting functionality.

My only guess after hitting a wall with it is that what the Ramda is doing to process the input is ignoring/blocking the commenting functionality.

I hope someone is able to chip in and help get this feature added. I'm happy to help in any way if there is something that I am obviously missing.

Thanks!

@JasonSooter JasonSooter closed this Jan 7, 2019
@CrossEye

CrossEye commented Jan 8, 2019

Copy link
Copy Markdown
Member

@functionalStoic:

Sorry this was dropped. I don't think there is anyone really looking at this repo any more.

@JasonSooter

Copy link
Copy Markdown
Author

@CrossEye No worries at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants