[RushikeshBhavsar3605]

Summary

Fix product creation failing when the product description is empty.

Changes

• Omit the Stripe description parameter when the product description is empty.
• Preserve the existing behavior when a description is provided.
• Add a regression test covering empty product descriptions.

Test Plan

• go test ./billing/product
• Reproduced the issue end-to-end using a Stripe test account.
• Verified that creating a product with an empty description now succeeds.

Closes #1853

[vercel]

@RushikeshBhavsar3605 is attempting to deploy a commit to the Raystack Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a4831c36-9ef5-4d0d-bfce-e55f0872be41

📥 Commits

Reviewing files that changed from the base of the PR and between 3fa7284 and 8ddebeb.

📒 Files selected for processing (1)

• billing/product/service_test.go

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Product creation now handles empty descriptions correctly.
  • Products without descriptions are sent to the payment provider without an unnecessary description value.
  • Product records remain successfully created and saved when no description is provided.
• Tests
  • Added coverage for successful product creation, persistence, and payment-provider requests involving empty descriptions.

Walkthrough

Product creation now omits the Stripe description parameter when the description is empty. Tests verify successful persistence and a nil Stripe description parameter.

Changes

Product creation

Layer / File(s)	Summary
Stripe description handling billing/product/service.go, billing/product/service_test.go	Product creation builds reusable Stripe parameters and assigns Description only when non-empty. Tests cover empty-description creation, persistence, and the Stripe request expectation.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🔵 Low · up to 8ddeb

The change correctly omits an empty Stripe description, while the regression test name does not match its successful expectation and could cause minor maintenance confusion. The PR is mergeable with explicit owner awareness or a follow-up rename.

Suggested reviewers: rohilsurana

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR omits Stripe description when empty, preserves non-empty behavior, and adds regression coverage; the separate plan-state defect is explicitly outside this PR's scope.
Out of Scope Changes check	✅ Passed	All production and test changes directly support preventing Stripe failures for empty product descriptions.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8aa6608a-710c-4afa-8829-01626fb79b52

📥 Commits

Reviewing files that changed from the base of the PR and between 4fb6f25 and 3fa7284.

📒 Files selected for processing (2)

• billing/product/service.go
• billing/product/service_test.go

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

[rohilsurana]

Are there any other stripe fields that have similar behaviour and we need to take care of?

[RushikeshBhavsar3605]

I checked the Stripe product/price fields for the same empty-description behavior and didn't find another occurrence.