Skip to content

fix(billing): show the credit purchase amount as a formatted price #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohanchkrabrty merged 4 commits into from
Sep 25, 2026
Merged

fix(billing): show the credit purchase amount as a formatted price #1948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dad2590
fix(billing): print the credit purchase amount as a whole number
rohanchkrabrty Sep 25, 2026
5fff6c0
test(billing): drop the credit description test
rohanchkrabrty Sep 25, 2026
a777b3a
fix(billing): show the credit purchase amount in the currency's major…
rohanchkrabrty Sep 25, 2026
56fa544
fix(billing): show the credit purchase amount with its currency code
rohanchkrabrty Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions billing/checkout/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,14 @@ import (
"errors"
"fmt"
"log/slog"
"math"
"strings"
"sync"
"time"

"github.com/robfig/cron/v3"
"github.com/stripe/stripe-go/v79"
"golang.org/x/text/currency"

"github.com/raystack/frontier/billing"
billingerrors "github.com/raystack/frontier/billing/errors"
Expand Down Expand Up @@ -641,8 +643,8 @@ func (s *Service) ensureCreditsForProduct(ctx context.Context, ch Checkout) erro

description := fmt.Sprintf("addition of %d credits for %s", creditAmount, chProduct.Title)
if price, pok := ch.Metadata[AmountTotalMetadataKey]; pok {
if currency, cok := ch.Metadata[CurrencyMetadataKey].(string); cok {
description = fmt.Sprintf("addition of %d credits for %s at %d[%s]", creditAmount, chProduct.Title, price, currency)
if cur, cok := ch.Metadata[CurrencyMetadataKey].(string); cok {
description = fmt.Sprintf("addition of %d credits for %s at %s", creditAmount, chProduct.Title, formatAmount(cast.ToInt64(price), cur))
}
}
initiatorID := ""
Expand All @@ -666,6 +668,17 @@ func (s *Service) ensureCreditsForProduct(ctx context.Context, ch Checkout) erro
return nil
}

// formatAmount renders a Stripe amount, given in the currency's minor unit,
// in its major unit, e.g. 1000 usd as 10.00 USD
func formatAmount(minor int64, cur string) string {
unit, err := currency.ParseISO(strings.ToUpper(cur))
if err != nil {
return fmt.Sprintf("%d[%s]", minor, cur)
}
scale, _ := currency.Standard.Rounding(unit)
return fmt.Sprintf("%.*f %s", scale, float64(minor)/math.Pow10(scale), unit)
}

func (s *Service) checkIfAlreadySubscribed(ctx context.Context, ch Checkout) (string, error) {
// check if subscription exists
subs, err := s.subscriptionService.List(ctx, subscription.Filter{
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,6 @@ require (
golang.org/x/exp v0.0.0-20250911091902-df9299821621 // indirect
golang.org/x/sys v0.47.0 // indirect
golang.org/x/term v0.45.0 // indirect
golang.org/x/text v0.40.0 // indirect
golang.org/x/text v0.40.0
gopkg.in/ini.v1 v1.67.0 // indirect
)
Loading